Open
Conversation
The regex has been catching "+"; "$"; "^"; "|"; "~" and "`", really annoying issue. I might be dumb and catching those might have an actual use, but as far as I can tell it's nothing more than an annoying issue. Also I'm sure there is a better way of going about it, but I'm tired and cannot be bothered to do regex.
I'm dumb, there was a significantly better way of doing it.
Previous "fix" just rendered the expression useless, this should be an actual fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The regex has been catching "+"; "$"; "^"; "|"; "~" and "`", really annoying issue. I might be dumb and catching those might have an actual use, but as far as I can tell it's nothing more than an annoying issue.
Also I'm sure there is a better way of going about it, but I'm tired and cannot be bothered to do regex.