fix/annotation-list-class-order#245
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the AnnotationList toolbox item to render class-group headers in a deterministic order that matches the configured class definition order, and adds persistence for the list’s checkbox UI options via localStorage.
Changes:
- Render grouped class headers in
AnnotationListbased onsubtask.class_defsorder (with a fallback for unknown/orphan class IDs). - Persist and restore
show_deprecated+group_by_classcheckbox states inlocalStorage. - Add an e2e test that asserts grouped header ordering follows
class_defsorder (including after a runtime reversal).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/e2e/annotation_list.spec.js | Adds an e2e regression test for class-group header ordering. |
| src/toolbox_items/annotation_list.ts | Implements class_defs-ordered grouping and persists/restores checkbox state via localStorage. |
| CHANGELOG.md | Adds release notes for 0.23.6. |
| src/version.js | Bumps runtime version constant to 0.23.6. |
| package.json | Bumps package version to 0.23.6. |
…d helper function to build class def map
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix/annotation-list-class-order
Description
AnnotationListclass ordering to match theAnnotationIDtoolbox item ordering, which is based on the configured class definition order in the subtask'sclassesarrayAnnotationListtoolbox itemPR Checklist
package.jsonhas been bumped since last releasepackage.jsonandsrc/version.jsapi_spec.md)changelog.mdBreaking API Changes
AnnotationList class ordering is now based on the subtask order and not class id