Conversation
Task 429822: IRCC - Smart Snippet PR to remove “show less”: https://dev.azure.com/CoveoPS/ESD%20Canada%20TA%20work/_workitems/edit/429822
Fix for WCAG focus order
There was a problem hiding this comment.
@bblaisATcoveo Few changes based on conversations with CEO and aligned with their recommendations:
Details of changes requested:
- In yellow: please make the invisible H4 heading a visible H3 heading instead (see the next bullet for why it is changing to H3). and replace the text value for "Source:" (add a space for the colon in French) which is more clear than "Taken from:". Also, the font size of that heading should be changed to match the search results link that are also H3. Note: This was flagged as an issue by our Accessibility Center of Excellence team at ESDC.
- In pink-ish: Move the smart snippet box ABOVE the number of results (query summary), which makes more sense semantically and is in line with what we are doing for Triggers. By doing this, you will have to change the heading of the snippet to be an H2 instead of an H3 (but please keep the same font size as we currently have), and the source as H3 semantically. Reminder to please make sure that the focusToView() still works.
- In green: remove a bit of the spacing between the snippet itself and the Show more button, they look visually disconnected right now (you could probably change the padding of the snippet to be 0 instead of 20px 0, and then specify a padding top only at 20px. Additionally, for the Show more button itself, please add the class btn-lg to make the text slightly larger and please add a bit of breathing space between the text and the chevron-down icon (this change was not indicated in the screenshot, I thought of it after).
- In blue: please make sure that the spacing makes sense visually; especially the top margin which is most likely to be too small when simply moving the HTML element around without adding CSS for top spacing.
- Finally, not in color, but please make sure that the breadcrumb fix done recently applies to the source of the snippet as well.
Then, we'll be able to resubmit to accessibility for final review :) Thank you!
CC: @ipaksc
|
Additionally, @bblaisATcoveo please provide test cases; we will need to have a simple example that we can leverage from Non Production to make the snippets display. Additionally, I want to make sure that the People also ask section was not forgotten about for testing and accessibility (@ipaksc was it assessed by the center of excellence?), so please @bblaisATcoveo let's make sure that the test does include a People also ask section. We can work together as a team to discuss the sample test. For that section, is it still planned to always be at the bottom? And please note that I personally did not include People also ask in my previous review of this PR, the sample test will help. |


Add UI support for smart snippets feature