feat: add truthful native goal integration evidence - #10
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1972ee152f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const previousStatus = found.run.status; | ||
| let nextStatus = transitionRun(previousStatus, options.event); | ||
| if (options.event === "add-budget") { | ||
| if (options.event === "interrupt") { |
There was a problem hiding this comment.
Block result intake while interrupted
When this path records an interrupt, it only changes the run status and leaves the active task/checkpoint in running; existing recordWorkflowResult only checks the task/checkpoint state, so if the interrupted checkpoint later submits a task result, CEWP accepts it and can promote the run back to active without the explicit resume action while retaining a stale interruption marker. That bypasses the host-resume gate and lets verification evidence mutate core state during an interrupted workflow.
AGENTS.md reference: AGENTS.md:L5-L5
Useful? React with 👍 / 👎.
| if (event.source.path === "explicit-intake" && binding.mode !== "explicit-intake") { | ||
| throw new Error("Explicit native goal events require an explicit-intake binding."); | ||
| } |
There was a problem hiding this comment.
Require app-server events to match managed bindings
These binding checks reject mismatched plugin and explicit-intake events, but leave app-server unchecked; with a graduated app-server capability, an app-server native-goal event is accepted against a native explicit-intake binding as long as the goal id matches, and can pause/resume/cancel that native run. That mixes a managed app-server source into a native checkpoint instead of enforcing the binding's single execution owner/source.
AGENTS.md reference: AGENTS.md:L6-L6
Useful? React with 👍 / 👎.
Summary
Safety boundaries
Validation
npm run checknpm run pack:dry-rungit diff --checkValidation was run against exact PR head
1972ee1.