fix: update bits button selectors and suppress prod console logs#1208
Open
dcmclarke wants to merge 4 commits intoSevenTV:masterfrom
Open
fix: update bits button selectors and suppress prod console logs#1208dcmclarke wants to merge 4 commits intoSevenTV:masterfrom
dcmclarke wants to merge 4 commits intoSevenTV:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1187
The "Hide Bits Buttons" setting stopped working because Twitch updated
their UI. The old selectors (data-a-target="bits-button" for the balance
button) seems to no longer exist on the page.
So checked out the current Twitch DOM, the bits/channel points balance
button now uses aria-label="Bits and Points Balances". So Twitch has merged
the bits and channel points balance into a single combined button which makes it
impossible to hide bits without also hiding channel points. The cheer
button (data-a-target="bits-button") selector still works and has been kept.
Note: Due to Twitch combining bits and channel points into one button,
enabling "Hide Bits Buttons" will also hide the channel points balance.
Users who want to keep channel points visible can use the separate
"Hide Channel Point Balance Button" setting instead.
Below chat
Top of screen (above chat)
Types of changes
Also suppresses [INFO] and [DEBUG] logs in production builds via the Logger class (Closes #1203)