fix(logger): suppress info and debug logs in production builds#1210
Open
dcmclarke wants to merge 4 commits intoSevenTV:masterfrom
Open
fix(logger): suppress info and debug logs in production builds#1210dcmclarke wants to merge 4 commits intoSevenTV:masterfrom
dcmclarke wants to merge 4 commits intoSevenTV:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1203
Proposed changes
In prod builds, Logger printing [INFO] and [DEBUG] messages to the browser console, creating unnecessary noise for users and developers. Added a check in the Logger's print method to suppress info and debug level logs when running in a prod build, while keeping warn and error logs visible as these indicate actual problems. Errors and warnings are still shown in all builds as these indicate real issues.
Types of changes
Checklist
Screenshots
Before
After