Prepare 0.1.8 and make the release gate runnable on PowerShell 5.1 - #10
Merged
Merged
Conversation
The plugin version is bumped for the release carrying Stagehand stages, the viewport capture fix and the Chronicle additions. tools/smoke-server.ps1 assumed PowerShell 7: Windows PowerShell 5.1 does not load System.Net.Http by default, so the release gate failed before reaching any of the checks it exists to perform. A release gate has to run on the shell the release machine actually has. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
ProcessStartInfo.ArgumentList and Process.Kill(entireProcessTree) are both .NET Core only, so the release gate still could not start or stop its test server on Windows PowerShell 5.1. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
-Encoding utf8NoBOM does not exist on Windows PowerShell 5.1, so the release gate passed every check and then failed on its last line. Writing the file directly also guarantees no BOM, which would break sha256sum -c. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small changes ahead of the 0.1.8 release.
Version bump to
0.1.8.0for the release carrying Stagehand stages, the viewport capture fix and the Chronicle additions (#9).tools/smoke-server.ps1portability. It assumed PowerShell 7. Windows PowerShell 5.1 does not loadSystem.Net.Httpby default, so the release gate died withUnable to find type [System.Net.Http.HttpClient]before reaching any of the checks it exists to perform — meaning step 2 ofdocs/RELEASING.mdcould not run at all on a machine with only 5.1 installed. Now guarded with anAdd-Typethat is a no-op on 7.🤖 Generated with Claude Code