Serve profile gallery images, and cut 0.1.11 - #15
Merged
Merged
Conversation
Every profile portrait returned 404 while its bytes sat on disk, so no card has
ever shown a face.
Beacon screenshots and profile gallery images share one image store but keep
separate metadata tables. The serve endpoint looked the id up only in the
screenshot table, so an id that was a perfectly good portrait was reported
missing. It now falls back to the gallery table, which stores no content type
because everything in the store is written as WebP.
Verified against a local server: full and thumbnail, WebP and PNG, all four
return 200 with the right content type. Production logs show the 404s this
fixes:
GET /images/2ded7529-... 404 0
GET /images/67ca1af5-... 404 0
Also: "Seen 1 days ago" now reads "Seen yesterday".
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every profile portrait has been 404ing
No card has ever shown a face. The bytes were on disk the whole time.
Beacon screenshots and profile gallery images share one image store but keep separate metadata tables.
ServeAsynclooked the id up only indb.Images(BeaconImageEntity, screenshots), so an id that was a perfectly good portrait indb.ProfileImageswas reported missing.Production logs, captured while reproducing it:
The lookup now falls back to the gallery table. That table stores no content type, because everything in the store is written as WebP.
Verified against a local server — full and thumbnail, WebP and PNG:
This is a server-side fix, so existing 0.1.10 clients start showing portraits as soon as the server updates.
Also in this cut: "Seen 1 days ago" now reads "Seen yesterday", and the version and stack tags move to 0.1.11.
🤖 Generated with Claude Code