Lead the card with the likeness, and open pictures full size - #16
Merged
Merged
Conversation
The portrait leads ------------------ It was a hundred-pixel thumbnail beside a column of text, with half the card left empty. It now sits centred at the top at roughly half the card's width, and everything else reads beneath it. A face is what somebody actually decides on, so it gets the room; the rest scrolls. Pictures open ------------- Clicking a likeness opens it full size, in a window that can be resized and moved. Gallery images open the same way. The gallery button did nothing at all, and could not have worked: the card draws inside a child window, and an ImGui popup opened from inside a child cannot be begun outside it -- the id stacks do not match, so BeginPopupModal never matches the OpenPopup and the popup silently never appears. The viewer is a window rather than a popup, which has no such coupling, and the card now reports what the reader clicked instead of owning popup state it cannot draw. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The portrait leads
It was a 100px thumbnail beside a column of text with half the card left empty. It now sits centred at the top at roughly half the card's width (clamped 220–460px), with everything else beneath it. A face is what somebody actually decides on, so it gets the room; the rest scrolls.
Pictures open full size
Clicking a likeness opens it in a resizable, movable window, scaled to fit without cropping or distorting. Gallery images open the same way.
Why the gallery button did nothing
It could not have worked. The card draws inside
BeginChild("##cardPage"), andImGui.OpenPopupcalled from inside a child pushes onto that child's id stack — whileBeginPopupModalwas called afterEndChild(), at the parent level. The ids never match, so the popup silently never appears. The same reason the preview's gallery button did nothing.The viewer is now a
Windowrather than a popup, which has no such coupling and is resizable into the bargain.ProfileCardreports what the reader clicked (OpenImage,OpenGallery) instead of owning popup state it is structurally unable to draw.Audit and full Release build pass.
🤖 Generated with Claude Code