feat: add close confirmation dialogs for tabs and windows#16

Merged

Shadow-Azure merged 26 commits into

mainfrom

feat/close-confirmation-dialogs

Jun 2, 2026

Commits on Jun 1, 2026

docs: add design spec for close confirmation dialogs

ZN-Ice
and
claude
committed
docs: add implementation plan for close confirmation dialogs

ZN-Ice
and
claude
committed
feat(electron): add IPC bridge for window close coordination

ZN-Ice
and
claude
committed
feat(electron): intercept window close with confirmation flow

ZN-Ice
and
claude
committed
fix(electron): add timeout to window close confirmation flow

ZN-Ice
and
claude
committed
feat(ui): add close confirmation dialogs for tabs and windows

ZN-Ice
and
claude
committed
fix(ui): fix stale closure in doCloseTab active tab selection
ZN-Ice
committed
fix(electron): address review findings — type mismatch, dismiss consistency, double-close guard

ZN-Ice
and
claude
committed

Commits on Jun 2, 2026

fix(electron): defer WebSocket creation in connectPty to prevent early message loss

ZN-Ice
and
claude
committed
test: add jsdom, testing-library, playwright dependencies and vitest setup

ZN-Ice
and
claude
committed
test(connectPty): add WebSocket mock and deferred connection unit tests

ZN-Ice
and
claude
committed
test(tabManagement): extract tab state logic and add unit tests

ZN-Ice
and
claude
committed
test(captureToPng): add buffer fallback tests with white background detection

ZN-Ice
and
claude
committed
test(playwright): add E2E config with mocked IPC fixtures

ZN-Ice
and
claude
committed
test(e2e): add terminal screenshot visual regression — dark theme validation

ZN-Ice
and
claude
committed
test(e2e): add tab creation visual regression tests

ZN-Ice
and
claude
committed
test: add test.sh, rename vite.config.ts for electron-vite, add .gitignore

ZN-Ice
and
claude
committed
ci: add Playwright E2E job to CI gate

ZN-Ice
and
claude
committed
fix: typecheck errors in connectPty tests, add CI retries for flaky E2E

ZN-Ice
and
claude
committed
fix(e2e): handle platform-specific snapshots for CI

ZN-Ice
and
claude
committed
fix(e2e): skip visual regression tests on CI, add update-snapshots flag

ZN-Ice
and
claude
committed
fix(test): fix daemon test isolation, add test.sh to CI

ZN-Ice
and
claude
committed
fix(ci): use bash instead of sh for test.sh in CI

ZN-Ice
and
claude
committed
fix(ui): use correct endpoint for tab close

ZN-Ice
and
claude
committed
fix(e2e): prevent Vite from opening browser during Playwright tests

ZN-Ice
and
claude
committed
fix(ui): use closeSandbox() for Close All Terminals action

ZN-Ice
and
claude
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add close confirmation dialogs for tabs and windows#16

feat: add close confirmation dialogs for tabs and windows#16
Shadow-Azure merged 26 commits into
mainfrom
feat/close-confirmation-dialogs

Commits on Jun 1, 2026

docs: add design spec for close confirmation dialogs

docs: add implementation plan for close confirmation dialogs

feat(electron): add IPC bridge for window close coordination

feat(electron): intercept window close with confirmation flow

fix(electron): add timeout to window close confirmation flow

feat(ui): add close confirmation dialogs for tabs and windows

fix(ui): fix stale closure in doCloseTab active tab selection

fix(electron): address review findings — type mismatch, dismiss consistency, double-close guard

Commits on Jun 2, 2026

fix(electron): defer WebSocket creation in connectPty to prevent early message loss

test: add jsdom, testing-library, playwright dependencies and vitest setup

test(connectPty): add WebSocket mock and deferred connection unit tests

test(tabManagement): extract tab state logic and add unit tests

test(captureToPng): add buffer fallback tests with white background detection

test(playwright): add E2E config with mocked IPC fixtures

test(e2e): add terminal screenshot visual regression — dark theme validation

test(e2e): add tab creation visual regression tests

test: add test.sh, rename vite.config.ts for electron-vite, add .gitignore

ci: add Playwright E2E job to CI gate

fix: typecheck errors in connectPty tests, add CI retries for flaky E2E

fix(e2e): handle platform-specific snapshots for CI

fix(e2e): skip visual regression tests on CI, add update-snapshots flag

fix(test): fix daemon test isolation, add test.sh to CI

fix(ci): use bash instead of sh for test.sh in CI

fix(ui): use correct endpoint for tab close

fix(e2e): prevent Vite from opening browser during Playwright tests

fix(ui): use closeSandbox() for Close All Terminals action