fix(npm): add .npmignore to platform packages to include binaries#31
Merged
Conversation
The root .gitignore excludes packages/*/bin/ and packages/*/app/ to prevent build artifacts from being committed. However, npm uses .gitignore by default when deciding what to publish, which caused the platform packages to be published without the actual binaries. Users installing cli-box-skill via npm would get empty platform packages, causing the postinstall script to fail silently and the cli-box wrapper to not find the binary. Fix: Add .npmignore files to platform packages that override the .gitignore behavior, ensuring binaries are included in published packages. Closes #<issue-number>
🔒 门禁检查结果
Rust 测试覆盖率
前端测试覆盖率
✅ 所有检查通过，可以合入
|
The E2E skill installation test was hanging on 'cli-box start zsh' command because it waits for renderer WebSocket and terminal readiness (up to 125 seconds). In test environments where Electron cannot start (due to permissions or display issues), this causes the test to hang. Fix: Add 30-second timeout to the functional test. If the command doesn't complete within the timeout, skip the test with a warning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After installing cli-box-skill via npm, users get an error that cli-box-skill is not installed. The root cause is that the platform-specific npm packages (cli-box-darwin-arm64, cli-box-electron-darwin-arm64) are published without the actual binaries.
Root Cause:
Solution
Fix 1: Add .npmignore to platform packages
Add files to the platform packages that override the behavior, ensuring binaries are included in published packages.
Changes:
Fix 2: Add timeout to E2E functional test
The E2E skill installation test was hanging on 'cli-box start zsh' command because it waits for renderer WebSocket and terminal readiness (up to 125 seconds). In test environments where Electron cannot start (due to permissions or display issues), this causes the test to hang.
Changes:
==============================================
E2E Skill Installation Tests
�[0;32m➜�[0m Test 1: npm postinstall.mjs
�[0;32m➜�[0m Running postinstall.mjs...
➜ Platform: darwin-arm64
✓ Found platform package: cli-box-darwin-arm64
✓ cli-box → /Users/zn-ice/2026/cli-box/.claude/worktrees/fix+npm-binary-deps/packages/cli-box-darwin-arm64/bin/cli-box
✓ cli-box-daemon → /Users/zn-ice/2026/cli-box/.claude/worktrees/fix+npm-binary-deps/packages/cli-box-darwin-arm64/bin/cli-box-daemon
✓ SKILL.md → /var/folders/vv/bpm3blsn7zvglc8m_yh6hrw00000gn/T/tmp.V5w9MAk3BC/.claude/skills/cli-box/
✓ SKILL.md → /var/folders/vv/bpm3blsn7zvglc8m_yh6hrw00000gn/T/tmp.V5w9MAk3BC/.config/opencode/skills/cli-box/
cli-box installed successfully!
Add to PATH:
export PATH="$HOME/.cli-box/bin:$PATH"
Quick start:
cli-box start claude
cli-box start zsh
cli-box list
�[0;32m✓�[0m cli-box symlink created
�[0;32m✓�[0m cli-box-daemon symlink created
�[0;32m✓�[0m cli-box symlink target is executable
�[0;32m✓�[0m SKILL.md installed to .claude/skills/cli-box/
�[0;32m✓�[0m SKILL.md installed to .config/opencode/skills/cli-box/
�[0;32m✓�[0m SKILL.md has valid frontmatter delimiter
�[0;32m✓�[0m SKILL.md frontmatter contains 'name: cli-box'
�[0;32m✓�[0m SKILL.md frontmatter contains 'description'
�[0;32m➜�[0m Test 1 complete
�[0;32m➜�[0m Test 2: install.sh (GitHub Release path)
�[0;32m➜�[0m Building local tarball...
�[0;32m✓�[0m Local tarball built
�[0;32m➜�[0m Running install-local.sh...
==============================================
cli-box — Skill Installer
✓ Version: local
➜ Downloading cli-box-skill.tar.gz...
✓ Downloaded
➜ Extracting...
➜ Installing binaries to /var/folders/vv/bpm3blsn7zvglc8m_yh6hrw00000gn/T/tmp.zyMMDmhpnw/.cli-box/bin...
✓ Binaries installed
➜ Add to your PATH:
export PATH="$HOME/.cli-box/bin:$PATH"
➜ Add to ~/.zshrc or ~/.bashrc for persistence.
➜ Verifying installation...
✓ cli-box installed: cli-box 0.1.0
==============================================
Installation complete!
Quick start:
cli-box start claude # Start Claude Code sandbox
cli-box start zsh # Start zsh sandbox
cli-box list # List active sandboxes
Permissions required:
System Settings → Privacy & Security → Accessibility
System Settings → Privacy & Security → Screen Recording
�[0;32m✓�[0m cli-box binary installed and executable
�[0;32m✓�[0m cli-box-daemon binary installed and executable
�[0;33m⚠�[0m SKILL.md not installed (.claude/ dir may not exist in tmp HOME)
�[0;32m➜�[0m Test 2 complete
�[0;32m➜�[0m Test 3: Post-install verification
�[0;32m➜�[0m Verifying cli-box --help...
�[0;32m✓�[0m cli-box --help works
�[0;32m➜�[0m Verifying SKILL.md frontmatter...
�[0;32m✓�[0m SKILL.md frontmatter valid (name + description present)
�[0;32m➜�[0m Running functional test (cli-box start zsh)...
�[0;32m✓�[0m Sandbox f4bdd9 is running
Closing sandbox f4bdd9...
�[0;32m➜�[0m Test 3 complete
==============================================
�[0;32mAll E2E skill installation tests passed!�[0m - add 30-second timeout to functional test
Test Plan
🤖 Generated with Claude Code