Potential fix for code scanning alert no. 3: Uncontrolled data used in path expression - #17
Merged
Merged
Conversation
…n path expression Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
ShadowDara
marked this pull request as ready for review
September 13, 2026 21:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/ShadowDara/finder/security/code-scanning/3
Best fix: strictly validate cache template names as a single safe path component before building file paths.
That means rejecting names containing path separators (
/,\), parent traversal (..), empty values, and optionally names that normalize to".".Implement this in
internal/cache/cache.go(single source of truth), then call it in bothSaveCacheandLoadCachebeforefilepath.Join(...). This avoids changing functionality for normal template names while blocking traversal/path injection. Addfmtandstringsimports for validation error creation and checks. No route-level behavior changes are required; invalid names will naturally return an error and existing handlers already map errors to HTTP responses.Suggested fixes powered by Copilot Autofix. Review carefully before merging.