Skip to content

feat(locale): define GameDataLocale baseline and fixed data.bin loading#113

Open
KZdavid wants to merge 1 commit intoShadowTheAge:localefrom
KZdavid:feat/locale-base
Open

feat(locale): define GameDataLocale baseline and fixed data.bin loading#113
KZdavid wants to merge 1 commit intoShadowTheAge:localefrom
KZdavid:feat/locale-base

Conversation

@KZdavid
Copy link
Copy Markdown

@KZdavid KZdavid commented Apr 13, 2026

Summary

  • Introduce a minimal GameDataLocale baseline type for game-data language selection
  • Move game-data locale rationale into index.ts
  • Keep database loading fixed to ./data/data.bin
  • Remove locale-based database file selection logic

Notes

  • This is the base PR for the locale stack.

@KZdavid
Copy link
Copy Markdown
Author

KZdavid commented Apr 13, 2026

Quick clarification for this PR:

  • I noticed gameDataLocale is currently hardcoded to zh-CN, but it should default to en.
  • I also have a Chinese data export available for testing for GTNH 2.8.4 and can share it for validation: data.bin.zip
  • I’m preparing to upload my generated data.bin as a test artifact to help reproduce results.

@ShadowTheAge
Copy link
Copy Markdown
Owner

I am not currently adding things related to locale, only adding things related to removing hardcoded English texts as a groundwork for future locale packs.

@KZdavid
Copy link
Copy Markdown
Author

KZdavid commented Apr 13, 2026

I am not currently adding things related to locale, only adding things related to removing hardcoded English texts as a groundwork for future locale packs.

OK, I know. That way I will just pr #115 and I will remove the dependency on this pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants