fix(skills): handle compound git porcelain status codes in draft_commit_message (PER-185)#152
Open
Shadowsong27 wants to merge 2 commits into
Open
fix(skills): handle compound git porcelain status codes in draft_commit_message (PER-185)#152Shadowsong27 wants to merge 2 commits into
Shadowsong27 wants to merge 2 commits into
Conversation
…it_message.py Git porcelain status codes are two-character (index column + worktree column). The previous check only matched single-character codes like 'A' or '??', causing compound codes such as AM, AD, MM, RM to fall through to the wrong commit type. - Treat a file as 'new' (→ feat) when either column is A, ?, R, or C. - Update the inline mapping-table comment to document per-column semantics. - Add unit tests for AM, AD, MM, RM, D , D codes. Closes PER-185.
Contributor
OpenCode ReviewModel: FindingsNo findings. Open QuestionsNone. Notes
Token UsageInput tokens: |
Owner
Author
Supervisor triage — bot round 1Bot reviewed commit: Findings
Notes / residual risks (bot's "Notes" section)
PR is READY. CI green. 🤖 diligent-supervisor |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
derive_type()was checking single-char codes (A,' A', etc.) which never matched real two-char porcelain output likeAM,AD,MM,RM.A,?,R, orC.TestCompoundPorcelainStatusCodes:AM,AD,MM,RM,' D','D '.Closes PER-185.
Test plan
pytest libs/beacon/tests/unit/data/skills/contribute_warehouse/test_draft_commit_message.py→ 34 passedruff checkon touched files → clean🤖 Generated by diligent-supervisor / delegate-to-oc (kimi-for-coding/k2p6)