fix(deploy): install devDependencies and increase health check timeout#360
Open
DebuggingMax wants to merge 1 commit intoShaerWare:mainfrom
Open
fix(deploy): install devDependencies and increase health check timeout#360DebuggingMax wants to merge 1 commit intoShaerWare:mainfrom
DebuggingMax wants to merge 1 commit intoShaerWare:mainfrom
Conversation
- Add --include=dev to npm ci to ensure vue-tsc and other build tools are installed - Increase health check sleep from 5 to 20 seconds for slower startups Fixes ShaerWare#359
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #359
Changes
npm ci --include=dev: Ensures devDependencies (like
vue-tsc) are installed during deployment. Without this flag,npm ciskips devDependencies when NODE_ENV=production is set, causing build failures.Health check sleep 5 → 20 seconds: Gives the orchestrator more time to start before checking /health endpoint, reducing false warnings on slower systems.
Root Cause
The deploy script was running
npm ci --silentwhich respects NODE_ENV. In production environments where NODE_ENV=production, devDependencies are skipped. Sincevue-tscis a devDependency required for building the admin panel, the build would fail with "vue-tsc not found".