fix: npm ci --include=dev to install devDependencies#434
Open
DebuggingMax wants to merge 1 commit intoShaerWare:mainfrom
Open
fix: npm ci --include=dev to install devDependencies#434DebuggingMax wants to merge 1 commit intoShaerWare:mainfrom
DebuggingMax wants to merge 1 commit intoShaerWare:mainfrom
Conversation
Fixes ShaerWare#359 When NODE_ENV=production is set, npm ci skips devDependencies by default. This causes vue-tsc not to be found during the build step. Changed npm ci --silent to npm ci --include=dev to ensure devDependencies like vue-tsc are installed regardless of NODE_ENV setting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
NODE_ENV=productionis set,npm ciskips devDependencies by default. This causesvue-tsc(a devDependency) not to be found during the build step.Fixes #359
Solution
Changed
npm ci --silenttonpm ci --include=devindeploy.shline 51.The
--include=devflag explicitly tells npm to install devDependencies regardless of the NODE_ENV setting, ensuring build tools like vue-tsc are available.