fix: GSM init AT commands + monitor/AT race condition#542
Merged
Conversation
- Initialize: add AT+CMEE=2, AT+CRC=1, AT+CNMP=14 (force 2G/3G), AT+COPS=3,0, AT+CMGF=0 (PDU mode), AT+CNMI=2,1,0,0,0, AT+CMGD=1,4; remove AT+CSCS="UTF-8" (not supported by SIM7600E-H) - Monitor: skip reading while _serial_lock is held (fixes race condition where monitor steals AT command responses) - Monitor: handle +CRING:, +CMTI:, VOICE CALL: END - COPS parsing: fallback to unquoted operator name - CNUM parsing: use findall instead of search for robustness Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_serial_lockis held, preventing it from stealing AT command responsesfindallfor robustnessTest plan
nullfields in /admin/gsm/status🤖 Generated with Claude Code