fix(frontend): protect chart routes with auth guard and smart redirect #67
Merged
fix(frontend): protect chart routes with auth guard and smart redirect #67
Conversation
…he portfolio view. Added backend filtering to exclude positions with quantity = 0 from the portfolio view. This prevents "empty" assets from cluttering the list.
- Added a "Guard" (RequireAuth) to protect routes that require authentication. - Implemented a universal notification: "You must be logged in to access this page" for all protected routes. - Users trying to access private paths are now automatically redirected to the login page. - After a successful login, the system automatically redirects the user to their original destination. - Added a direct link to the Portfolio on the /me profile page.
dazw00110
added this to the
M2: Rating 4.5 (Portfolio, Alerty & Advanced Charts) milestone
dazw00110
added
bug
Hiltes
previously approved these changes
Jan 6, 2026
Collaborator
Hiltes
left a comment
Hiltes
left a comment
There was a problem hiding this comment.
Everything is OK, I dont saw any bugs
Shakalito
previously approved these changes
Jan 8, 2026
Owner
Shakalito
left a comment
Shakalito
left a comment
There was a problem hiding this comment.
Router looks good in the final version — no duplicate paths, and RequireAuth cleanly protects /chart/:listingId (and other private routes) with redirect-back behavior.
In future keep PR scope focused .
Shakalito
approved these changes
Jan 8, 2026
| { path: "/", element: <Navigate to="/me" replace /> }, | ||
| { path: "/login", element: <LoginPage /> }, | ||
| { path: "/register", element: <RegisterPage /> }, | ||
| { path: "/me", element: <MePage /> }, |
Owner
There was a problem hiding this comment.
Let's stay consistent here. Next time reformat the remaining routes to match the new multi-line style before we merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #44