Expand screenshot gallery, test coverage, and testing.md#16
Merged
Conversation
- Add spec/system/gallery_expansion_spec.rb: 67 new system-spec screenshots (numbers 104-170) covering every feature with multiple genuinely-different states (category management, footer message, reply prompt, new-topic prompt, pin-to-bottom, reply approval, private note, notes user-menu tab, first-post checklist, moderator whisper). - Add spec/requests/mod_messages_edge_cases_spec.rb: idempotency, param coercion, trust-level clamping, notes feed ordering, private-note position normalisation, note-reply id uniqueness. - Add test/javascripts/unit/linkify-message-extra-test.js: more URL/escaping/line-break edge cases for the shared message renderer. - docs/testing.md: append a section per new screenshot, matching the existing per-feature heading format. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
- linkify-message-extra-test.js: correct expectations now that escape
happens before regex linkification (so & becomes & in the URL,
and < has already become < by the time the URL regex runs).
- mod_messages_edge_cases_spec.rb: lengthen topic titles to pass the
15-char title-min and entropy validators.
- gallery_expansion_spec.rb:
- 148: was anonymous browse; the parent before-block had already
signed in a moderator. Switch to a TL1 user to assert non-staff
visibility.
- 106-108: pick selectors that exist on the category edit pages
instead of .category-edit-main-nav.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Pulls down the Frontend System Tests ui-screenshots artifact from the latest passing run and overwrites the gallery. 81 existing screenshots refreshed against the current UI; 91 new screenshots (104-170) added by the gallery_expansion_spec. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expands the discourse-mod plugin's screenshot gallery, system-spec coverage, and
docs/testing.md.What's added
67 new system-spec screenshots (numbers 104-170) across all 10 features in a new
spec/system/gallery_expansion_spec.rb:Additional tests:
spec/requests/mod_messages_edge_cases_spec.rb— idempotency, string-form approval-flag coercion, trust-level cap coercion + clamping, notes-feed ordering, private-note position normalisation (every input), note-reply id uniqueness, note-reply user attribution.test/javascripts/unit/linkify-message-extra-test.js— extra URL/HTML/line-break edge cases for the shared message renderer.docs/testing.mdgets a new section per feature group plus a### Header+ one-sentence description for every new screenshot, matching the existing format.Scope honoured
Only
spec/system/,spec/requests/,test/javascripts/,docs/testing.mdtouched.plugin.rb,lib/,app/,config/,assets/are untouched — every feature already ships on master.🤖 Generated with Claude Code