Fix for #114 - #115
Open
1sammy wants to merge 2 commits into
Open
Conversation
…tBorder manifesting as a NullPointerException and a broken arena in-game
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Added a check in the
GameBorderDataconstructor that preventscenterLocationsfrom becoming[null]instead of simplynullwhich caused a bug whereresetBorder()would not follow thethis.centerLocations.isEmpty()path when it should have, causing a NullPointerException and arena-breaking in-game behaviour (broken countdown, no pvp, player immortality).I'm not sure how this bug came to be as it seems impossible to avoid, possibly a change in truth-value behavior across java versions?
Target Minecraft Versions: any
Requirements: none
Related Issues: #114
Checklist before requesting a review
0001-null-centerLocations-causing-a-truthy-branch-in-Game.patch