Develop#663
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request focuses on simplifying the layout logic for video cards and navigation by removing the
cardSliderprop, standardizing card sizing, and improving responsive design. The changes streamline the codebase, making the layout more predictable and maintainable across different pages and devices.Layout and Responsiveness Improvements:
cardSliderprop fromMainNavbarand all its usages inApp.jsto simplify the navigation component's interface and reduce complexity. [1] [2] [3] [4] [5] [6]VideoCards.jsto always usewidth: 100%and a single-column layout when appropriate, ensuring consistent alignment and spacing.CARD_SIZE = 300inMainNavbar.js, and passed this value to children. [1] [2]Navigation and Toolbar Enhancements:
MainNavbar.jsfor both mobile and desktop, improving the alignment and spacing of search and controls.MainNavbar.jsto provide edge-to-edge layouts for media/list pages on mobile, while maintaining padding for forms and settings pages.Other:
1.7.0to1.7.1inpackage.json.