Develop#673
Merged
Merged
Conversation
…eshare port, added ability to edit the images created date
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a user-editable "Created Date" field for images, allowing authenticated users to set or update the creation date and time of an image via the UI. It refactors date field logic into a reusable component, ensures the new date is persisted to the backend, and updates the display of created dates throughout the app. Additionally, it improves Docker/Nginx configuration flexibility and documentation.
User-facing features:
DateFieldcomponent. (app/client/src/components/modal/EditImageModal.js,app/client/src/components/modal/UpdateDetailsModal.js,app/client/src/components/modal/DateField.js) [1] [2] [3]app/client/src/components/cards/MasonryImageCard.js)Backend and data handling:
created_atfield for images, storing it as a naive local datetime and handling invalid input gracefully. (app/server/fireshare/api/image.py)created_atvalue is propagated and reflected in the UI after edits. (app/client/src/views/FolderView.js,app/client/src/views/GameVideos.js,app/client/src/views/ImageFeed.js) [1] [2] [3] [4]Refactoring and code reuse:
DateFieldcomponent, removing duplicate code and simplifying modal components. (app/client/src/components/modal/DateField.js,app/client/src/components/modal/UpdateDetailsModal.js) [1] [2]Docker/Nginx configuration and documentation:
FIRESHARE_PORTenvironment variable for more flexible port assignment. Updates documentation to reflect these changes. (Dockerfile,Dockerfile.lite,app/nginx/prod.conf,README.md) [1] [2] [3] [4]README.md)Versioning:
app/client/package.json,app/client/package-lock.json) [1] [2]