More mobile resizing fixes#674
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the app version and improves the UI responsiveness and accessibility for both the video and image feeds. The main changes include simplifying the grid layout logic in
VideoCards, enhancing the toolbar and selection controls inImageFeed, and updating the package version.UI and Responsiveness Improvements:
VideoCards.jsby removing the single-column logic andResizeObservercode, and switching to a more responsivegridTemplateColumnsdefinition. This makes the layout easier to maintain and improves responsiveness. [1] [2] [3]ImageFeed.jsfor better responsiveness on smaller screens by adjusting thegapproperty to use responsive values. [1] [2]Selection Controls and Accessibility:
ImageFeed.jsto show icons (DoneAllIcon/RemoveDoneIcon) instead of text on small screens, improving usability on mobile devices. [1] [2]Version Updates:
1.7.3in bothpackage.jsonandpackage-lock.jsonto reflect the new changes. [1] [2]