more enchantments#2
Open
dysbulic wants to merge 15 commits intoShareIt-project:masterfrom
dysbulic:master
Open
more enchantments#2dysbulic wants to merge 15 commits intoShareIt-project:masterfrom dysbulic:master
dysbulic wants to merge 15 commits intoShareIt-project:masterfrom
dysbulic:master
Conversation
simpleSignaling.js
Outdated
Member
There was a problem hiding this comment.
If 'configuration.room' is a falsy value (zero, false, empty list...) it will return false and then define room as 'default room', that's wrong. It's better to check explicitly that 'room' is not defined on the configuration object.
Contributor
Author
There was a problem hiding this comment.
I was unaware that those options were allowed falsy values. I can revert the changes.
Member
There was a problem hiding this comment.
It could be whatever. Depending on the application, a room '0' would be allowed... so better be on the safe side.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a couple things to the documentation and cleaned up the code a little.