Update sharkord-rss to v0.1.1 (security fixes)#6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sharkord-rss v0.1.1 — security patch over v0.1.0
This PR replaces the previously published v0.1.0 (PR #5) with v0.1.1, which fixes three security issues found shortly after the initial merge. The vulnerable
versions/0.1.0.jsonis removed in the same diff so users can no longer install the buggy version from the marketplace.🔒 Security fixes vs v0.1.0
isPrivateIPv4did not block100.64.0.0/10, leaving cloud-provider metadata endpoints (e.g. Alibaba's100.100.100.200) reachable. Now rejected.�triggered an unhandledRangeErrorinString.fromCodePoint, DoS-stopping the article parse. Numeric entities are now clamped to the valid Unicode range (<= 0x10FFFF).0:0:0:0:0:0:0:1and0000::1were not detected as loopback. Added a::-aware expander so every textual form is rejected.🩹 Reliability / DX improvements
syncFeedsFromSettingsnow run in parallel viaPromise.all.validatePublicHttpUrl).response.on('error')wraps inFeedErrorso everyfetchOncerejection carries a stable.code.setting:set, so we rely on the tick).🧪 Tests
50 unit tests added (
bun test) covering the security-critical helpers — including explicit regression cases for the three issues above. Pass on Bun 1.3.x.🗑 Files changed
plugins/sharkord-rss/versions/0.1.0.json→ removed (vulnerable; no longer reachable from the marketplace)plugins/sharkord-rss/versions/0.1.1.json→ added