You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
No actionable comments were generated in the recent review.
Walkthrough
Lane directions now carry Active, Valid, or None status from route calculation to icon rendering. Icon generation uses poi_lanes_inactive for directions with None status and poi_lanes for other statuses.
Changes: Lane direction status rendering
Layer / File(s)
Summary
Status-aware lane data map/src/route/lanes_group.rs, map/src/route/route_controller.rs
LanesInfo.dirs now stores directions with status. calc_route assigns Active, Valid, or None based on lane direction sets and sorts None statuses first.
Status-based lane icon styles map/src/route/lanes_group.rs, styles_v0.json
Icon generation retains the direction-to-SVG mappings and selects poi_lanes_inactive for None status, otherwise poi_lanes. styles_v0.json adds the inactive style.
sequenceDiagram
participant calc_route
participant LanesInfo
participant LanesGroup
participant styles_v0.json
calc_route->>LanesInfo: stores directions with Active, Valid, or None status
LanesInfo->>LanesGroup: supplies lane direction data
LanesGroup->>styles_v0.json: selects poi_lanes or poi_lanes_inactive
Loading
Possibly related PRs
ShashlikMap/shashlik-map#294: Adds the lane data structures and route-controller lane direction data that this PR updates.
ShashlikMap/shashlik-map#295: Adds the poi_lanes style and lane icon style selection that this PR extends with an inactive style.
ShashlikMap/shashlik-map#290: Extracts active and valid lane data that this PR uses to assign direction statuses.
Merge Risk: Minimal · up to d80bb
This change highlights the active or valid turn lanes and greys out the others. No concrete merge-blocking risk was identified, though the rendered appearance was not verified.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title "Highlight a turn maneuver" matches the main change. The PR adds a TurnLaneDirectionStatus model (None, Valid, Active) and marks turn-lane directions as Active or Valid. Icons for active or …
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Full details: Title check
Explanation
The title "Highlight a turn maneuver" matches the main change. The PR adds a TurnLaneDirectionStatus model (None, Valid, Active) and marks turn-lane directions as Active or Valid. Icons for active or valid turns use the poi_lanes style, while inactive turns use the new poi_lanes_inactive style. The title names the primary purpose of this change, which is highlighting the turn maneuver's lane directions.
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Warning
Some tools did not complete. Review the errors below.
Clippy (1.99.1)
Clippy execution timed out
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Reviewing files that changed from the base of the PR and between 2682efc and d80bb1c.
Files selected for processing: 3
map/src/route/lanes_group.rs
map/src/route/route_controller.rs
styles_v0.json
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary