Skip to content

Highlight a turn maneuver - #297

Merged
agent10 merged 2 commits into
mainfrom
turn_highlight
Nov 12, 2026
Merged

agent10 merged 2 commits into
mainfrom
turn_highlight

Conversation

@agent10

@agent10 agent10 commented Nov 12, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Turn-lane indicators highlighting

@coderabbitai

coderabbitai Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

Lane directions now carry Active, Valid, or None status from route calculation to icon rendering. Icon generation uses poi_lanes_inactive for directions with None status and poi_lanes for other statuses.

Changes: Lane direction status rendering

Layer / File(s) Summary
Status-aware lane data
map/src/route/lanes_group.rs, map/src/route/route_controller.rs
LanesInfo.dirs now stores directions with status. calc_route assigns Active, Valid, or None based on lane direction sets and sorts None statuses first.
Status-based lane icon styles
map/src/route/lanes_group.rs, styles_v0.json
Icon generation retains the direction-to-SVG mappings and selects poi_lanes_inactive for None status, otherwise poi_lanes. styles_v0.json adds the inactive style.

Estimated code review effort: 2 (Simple) | ~15 minutes

Change: Feature

Sequence Diagram(s)

sequenceDiagram
  participant calc_route
  participant LanesInfo
  participant LanesGroup
  participant styles_v0.json
  calc_route->>LanesInfo: stores directions with Active, Valid, or None status
  LanesInfo->>LanesGroup: supplies lane direction data
  LanesGroup->>styles_v0.json: selects poi_lanes or poi_lanes_inactive
Loading

Possibly related PRs

Merge Risk: Minimal · up to d80bb

This change highlights the active or valid turn lanes and greys out the others. No concrete merge-blocking risk was identified, though the rendered appearance was not verified.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title "Highlight a turn maneuver" matches the main change. The PR adds a TurnLaneDirectionStatus model (None, Valid, Active) and marks turn-lane directions as Active or Valid. Icons for active or …
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Full details: Title check

Explanation

The title "Highlight a turn maneuver" matches the main change. The PR adds a TurnLaneDirectionStatus model (None, Valid, Active) and marks turn-lane directions as Active or Valid. Icons for active or valid turns use the poi_lanes style, while inactive turns use the new poi_lanes_inactive style. The title names the primary purpose of this change, which is highlighting the turn maneuver's lane directions.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR

Warning

Some tools did not complete. Review the errors below.

Clippy (1.99.1)

Clippy execution timed out

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 2682efc and d80bb1c.

Files selected for processing: 3

  • map/src/route/lanes_group.rs
  • map/src/route/route_controller.rs
  • styles_v0.json

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

📸 Visual Regression (Pixel Eagle)

⚠️ Differences detected — 1 changed, 0 new, 0 missing, 2 unchanged.

  • map-default-view changed by 1.24%

map-default-view

Golden recordThis PRDifference
map-globe-view (unchanged)

map-overlay-view (unchanged)

@agent10
agent10 marked this pull request as ready for review November 12, 2026 13:43
@agent10
agent10 merged commit 3b472f3 into main Nov 12, 2026
6 checks passed
@agent10
agent10 deleted the turn_highlight branch November 12, 2026 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant