[efficiency-improver] perf: replace Regex.IsMatch with char-based check in IsDisqusEnabled

[github-actions]

🤖 Efficiency Improver — automated AI assistant focused on reducing energy consumption and computational footprint.

Goal and Rationale

MasterModel.IsDisqusEnabled was calling System.Text.RegularExpressions.Regex.IsMatch(DisqusShortName, @"^[a-zA-Z0-9\-]+$") on every access. While .NET caches compiled regex patterns (up to Regex.CacheSize, default 15), each call still pays a cache-lookup cost at minimum. Since IsDisqusEnabled has no backing field (no field ??= memoisation), it re-evaluates on every view access — typically once per post-detail page render.

The pattern ^[a-zA-Z0-9\-]+$ is fully expressible as a character-predicate: every character must be an ASCII letter, ASCII digit, or a hyphen. This is exactly what char.IsAsciiLetterOrDigit(c) || c == '-' checks.

Focus Area

Code-Level Efficiency — eliminating regex engine overhead on a per-request validation call.

Approach

Replaced the Regex.IsMatch(...) call with DisqusShortName.All(c => char.IsAsciiLetterOrDigit(c) || c == '-').

• char.IsAsciiLetterOrDigit uses an O(1) lookup table (ASCII range check).
• Enumerable.All short-circuits on the first non-matching character.
• Zero allocations — no Regex object, no match state, no cache lookup.
• Semantically equivalent: IsNullOrWhiteSpace already ensures non-empty; All over non-empty string mirrors + (one or more) quantifier.

Energy Efficiency Evidence

Proxy metric: CPU cycles per property access (fewer instructions = less power draw).

Aspect	Before	After
Regex cache lookup	Yes (dict lookup per call)	None
Regex object allocation	Amortised (cached)	None
Per-character work	DFA state transition	IsAsciiLetterOrDigit table lookup
Allocations per call	~0 (regex cached)	0 (lambda is static)
Short-circuit on first bad char	Yes (DFA)	Yes (All)

For a blog with Disqus enabled, every post detail page render calls IsDisqusEnabled. At modest load (1000 post views/hour), this eliminates 1000 regex cache lookups per hour — small per-call savings that compound at scale.

Green Software Foundation context — Hardware Efficiency: using the CPU's native ASCII lookup table instead of a generalised regex engine makes better use of the hardware for this specific, well-constrained check.

Trade-offs

None. The LINQ char-check is arguably more readable than the regex for this simple pattern, and is semantically identical.

Reproducibility

# Before: set Disqus shortname to "my-blog", profile IsDisqusEnabled calls with dotnet-trace
# Regex.IsMatch appears in allocation/CPU samples
# After: no Regex frames in the call stack

Test Status

Build blocked in sandbox by Nerdbank.GitVersioning (requires fetch-depth: 0 git clone). This is a known infrastructure limitation. CI will validate on merge.

Generated by Efficiency Improver · sonnet46 3M · ◷

Add this agentic workflows to your repo

To install this agentic workflow, run

gh aw add githubnext/agentics/workflows/efficiency-improver.md@dcdf09723d42ef9b6c75335e4612fd145d4ccdaa