Skip to content

Bump Umbraco 17.4.0 and update CI build workflow#488

Open
gavinfaux wants to merge 3 commits into
Shazwazza:developfrom
gavinfaux:pr/17.4
Open

Bump Umbraco 17.4.0 and update CI build workflow#488
gavinfaux wants to merge 3 commits into
Shazwazza:developfrom
gavinfaux:pr/17.4

Conversation

@gavinfaux
Copy link
Copy Markdown
Contributor

  • bump Markdig 0.45.0 (match Umbraco 17.4.0)
  • bump FileSignatures 7.1 (updates transitive dependency OpenMcdf to 3.1.4)
  • bump Microsoft.NET.Test.Sdk 18.4.0
  • bump pnpm 11.4.0 and reinstall dependencies
  • amend pnpm version to read from package.json packageManager field
  • bump GitHub actions to latest
  • amend dotnet version to dynamically match newest feature band

gavinfaux added 2 commits June 2, 2026 19:49
- bump Markdig 0.45.0 (match Umbraco 17.4.0)
- bump FileSignatures 7.1 (updates transitive dependency OpenMcdf to 3.1.4)
- bump Microsoft.NET.Test.Sdk 18.4.0
- bump pnpm 11.4.0 and reinstall dependencies
- bump GitHub actions to latest
- amend dotnet version to dynamically match newest feature band
- pnpm version read from package.json `packageManager` field
Copilot AI review requested due to automatic review settings June 2, 2026 19:25
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates the project’s minimum supported Umbraco 17 version to 17.4.0 and refreshes build/dependency tooling to match, including .NET, Docker, and CI configuration.

Changes:

  • Bumped Umbraco 17 minimum version references to 17.4.0 across docs, build props, Docker, and compose config.
  • Updated several dependencies/tooling versions (e.g., FileSignatures, Markdig, pnpm, GitHub Actions).
  • Removed OpenMcdf package references and version property.

Reviewed changes

Copilot reviewed 15 out of 16 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
umbraco-marketplace-readme.md Updates documented minimum Umbraco 17 requirement to 17.4.0.
src/Articulate/Articulate.csproj Updates package versions; removes OpenMcdf reference.
src/Articulate.Web/Client/package.json Bumps pnpm version via packageManager.
src/Articulate.Web/Articulate.Web.csproj Mirrors dependency updates; removes OpenMcdf reference.
src/Articulate.Tests/Articulate.Tests.csproj Updates test SDK; removes OpenMcdf reference.
src/Articulate.Tests.Website/Articulate.Tests.Website.csproj Removes OpenMcdf reference.
global.json Adjusts pinned .NET SDK version and roll-forward behavior.
docker-compose.yml Updates default Umbraco 17 version range to start at 17.4.0.
build/docker-site/ArticulateDockerSite.csproj Removes OpenMcdf reference.
RELEASE_NOTES.md Updates minimum Umbraco 17 requirement to 17.4.0.
README.md Updates minimum Umbraco 17 requirement to 17.4.0.
Dockerfile Updates Umbraco version range; changes .NET base images to floating 10.0 tags.
Directory.Build.props Updates net10 Umbraco version range; removes OpenMcdf version property.
.github/workflows/build.yml Updates action versions; adjusts pnpm and .NET SDK setup behavior.
.devcontainer/Dockerfile Bumps pnpm version used by corepack.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Dockerfile
Comment thread Dockerfile
@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented Jun 2, 2026

Greptile Summary

This PR bumps Umbraco to 17.4.0 as the minimum .NET 10 target and updates several related dependencies and toolchain versions throughout the project. It also cleans up explicit OpenMcdf pins now that FileSignatures 7.2.1 brings in the updated transitive dependency on its own.

  • Dependency updates: FileSignatures 6.1.1 → 7.2.1, Markdig 0.44.0 → 0.45.0, Microsoft.NET.Test.Sdk 18.0.1 → 18.4.0; all explicit OpenMcdf PrivateAssets references removed from four projects.
  • CI / toolchain: GitHub Actions bumped to latest minor/patch releases; .NET SDK version spec switched from pinned patches to floating 9.0.x / 10.0.x; global.json rollForward changed from latestPatch to latestFeature; pnpm version read from package.json packageManager field instead of a hardcoded workflow value.
  • Docker: SDK and runtime image tags changed from pinned patch versions to floating 10.0, matching the intent of the broader "track latest feature band" strategy.

Confidence Score: 5/5

This PR is safe to merge — all changes are routine dependency and toolchain version bumps with no logic modifications.

Every changed file is either a version number, a lock file regeneration, or a documentation update. The removal of explicit OpenMcdf pins is intentional and covered by the updated FileSignatures transitive dependency. The switch to floating SDK and Docker image tags is a deliberate policy change described in the PR.

No files require special attention.

Important Files Changed

Filename Overview
.github/workflows/build.yml Action versions bumped; pnpm version now read from package.json; .NET SDK versions switched to floating x-wildcards.
global.json rollForward changed from latestPatch to latestFeature and base version set to 10.0.100 to automatically track the newest installed feature band.
Directory.Build.props Removed OpenMcdfPackageVersion properties and bumped UmbracoCmsPackageVersion lower bound to 17.4.0 for the net10.0 target.
src/Articulate.Web/Articulate.Web.csproj FileSignatures bumped 6.1.1 to 7.2.1, Markdig 0.44.0 to 0.45.0, OpenMcdf explicit pin removed.
src/Articulate/Articulate.csproj FileSignatures bumped to 7.2.1, Markdig to 0.45.0; no other changes.
Dockerfile SDK and runtime base-image tags changed from pinned patch versions to floating major.minor tags (10.0), and UMBRACO_CMS_VERSION ARG default updated to 17.4.0.
src/Articulate.Web/Client/package.json packageManager field updated from pnpm@11.1.3 to pnpm@11.4.0.
src/Articulate.Tests/Articulate.Tests.csproj Microsoft.NET.Test.Sdk bumped 18.0.1 to 18.4.0; OpenMcdf pin removed.

Reviews (2): Last reviewed commit: "Merge branch 'Shazwazza:develop' into pr..." | Re-trigger Greptile

@gavinfaux gavinfaux marked this pull request as draft June 2, 2026 21:34
@gavinfaux gavinfaux marked this pull request as ready for review June 3, 2026 15:33
@gavinfaux
Copy link
Copy Markdown
Contributor Author

@Shazwazza ok to let the .NET SDK tags float for latest 9.0.x / 10.0.x or would you rather pin?

@Shazwazza
Copy link
Copy Markdown
Owner

@gavinfaux we can pin and have rollForward set

@gavinfaux
Copy link
Copy Markdown
Contributor Author

**Shazwazza **

   "version": "10.0.100",
    "rollForward": "latestFeature",

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants