-
Notifications
You must be signed in to change notification settings - Fork 2
[reference][native WIP] fix(native): pin iOS deployment target 15.5 + split smoke jobs (ERY-108) #600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
SheetMetalConnect
wants to merge
4
commits into
engineer/ery-99-native-smoke
from
engineer/ery-108-ios-pod-fix
+175
−21
Closed
[reference][native WIP] fix(native): pin iOS deployment target 15.5 + split smoke jobs (ERY-108) #600
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
01ffbcb
fix(native): pin iOS deployment target to 15.5 + split smoke jobs (ER…
SheetMetalConnect 4967746
ci(native): install JS deps in Android smoke job + add concurrency (E…
SheetMetalConnect 031ef00
ci(native): build Android smoke under JDK 21 (ERY-108)
SheetMetalConnect f7a567c
docs(native): record green split-lane evidence for ERY-108
SheetMetalConnect File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After splitting into
android-smoke, this job no longer runsnpm ci/npm install, but it still invokesnpm run android:assemble:*(which callsnpm run buildand needs local devDependencies likevite). On a fresh GitHub runner, these steps fail before any APK assemble, so the Android smoke lane is effectively broken and won’t provide the intended debug/release evidence.Useful? React with 👍 / 👎.