Open
Conversation
nopeslide
force-pushed
the
code_format_uncrustify
branch
from
0f0a71d to
5c20213
Compare
6 tasks
nopeslide
force-pushed
the
code_format_uncrustify
branch
from
5c20213 to
d0cbdcc
Compare
nopeslide
force-pushed
the
master
branch
2 times, most recently
from
bf436ac to
7e9728e
Compare
nopeslide
force-pushed
the
code_format_uncrustify
branch
from
760988f to
9d5ac5a
Compare
nopeslide
force-pushed
the
code_format_uncrustify
branch
2 times, most recently
from
4b1be2c to
dd551fd
Compare
nopeslide
commented
Apr 27, 2020
nopeslide
commented
Apr 30, 2020
Contributor
Author
|
uncrustify was updated so I updated everything |
ikstream
reviewed
May 5, 2020
Member
ikstream
left a comment
ikstream
left a comment
There was a problem hiding this comment.
A few minor thinks, but looks good to me so far
nopeslide
force-pushed
the
code_format_uncrustify
branch
2 times, most recently
from
c9d134f to
8af9a06
Compare
nopeslide
force-pushed
the
code_format_uncrustify
branch
6 times, most recently
from
2127cac to
c1590ac
Compare
nopeslide
force-pushed
the
code_format_uncrustify
branch
from
c1590ac to
012c81f
Compare
ikstream
reviewed
May 13, 2020
Member
ikstream
left a comment
ikstream
left a comment
There was a problem hiding this comment.
lgtm so far, except for the commented types of indentions
ikstream
approved these changes
Apr 29, 2021
Member
ikstream
left a comment
ikstream
left a comment
There was a problem hiding this comment.
Only one nitpick left from my side. Do we need to address this, or do you think it's OK to leave it that way?
| */ | ||
| #ifndef offsetof | ||
| #define offsetof(TYPE, MEMBER) ((size_t) &((TYPE *)0)->MEMBER) | ||
| # define offsetof(TYPE, MEMBER) ((size_t)&((TYPE*)0)->MEMBER) |
Member
There was a problem hiding this comment.
While it should work it does not look right to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues & PRs
Description
uncrustifyto format codecheck-uncrustifyto see if code format is needed.uncrustify.cfgconfigContext
uncrustifymay be better suited thanclang-formatfor our use-casesimply run
make check-uncrustifyto see what would change on formatTesting
make formatmake check-formatDocumentation