DEV-975 Add support for Bluetooth module version VELA_IF820_V01_04_18_18 - #291
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is small and low-risk (enum + recognition), with only a minor formatting issue noted.
Pull request overview
Adds recognition for a new VELA IF820 Bluetooth module firmware version within the driver’s Bluetooth module version parsing/identification logic.
Changes:
- Added
VELA_IF820_V01_04_18_18toBT_MODULE_VERSION. - Updated
isBtModuleVersionVelaIf820()to treat the new enum value as a VELA IF820 module.
File summaries
| File | Description |
|---|---|
| ShimmerDriver/src/main/java/com/shimmerresearch/driver/shimmer2r3/BluetoothModuleVersionDetails.java | Extends the known IF820 firmware versions and updates the IF820 detection helper accordingly. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is small, consistent with existing parsing logic, and correctly updates both the enum and the IF820 classification helper.
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0 new
- Review effort level: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for a new Bluetooth module firmware version in the
BluetoothModuleVersionDetailsclass. The main changes are:Support for new VELA IF820 firmware version:
VELA_IF820_V01_04_18_18enum value toBT_MODULE_VERSIONto represent the new firmware version.isBtModuleVersionVelaIf820()method to recognize the newVELA_IF820_V01_04_18_18version as a valid VELA IF820 module.