fix: numeric input clamping and Range Fill hotkey keystroke leak - #1464
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two interaction bugs:
InputSmallnow clamps numeric input to bothminandmax(previously onlymax, and not formax={0}), and pressing therhotkey no longer leaks anrinto the Range Fill modal's autofocused number input. Relates to the Range Fill flow inEditReleaseInfoModal.tsx.Changes
Fixed
InputSmall.tsx: honor amaxbound of0(the old truthiness checkmax && ...disabled clamping formax={0})InputSmall.tsx: enforceminsymmetrically — the prop was passed to the input but never checked in the handlerInputSmall.tsx: deliver out-of-range values through a prototype-cloned event target instead of mutating the sharedevent.target, which previously wrote through to the real DOM input outside React's controlled-value flowEditReleaseInfoModal.tsx:rhotkey now setspreventDefault: true(react-hotkeys-hook v5 only prevents default when explicitly asked), so the keystroke is no longer typed into the autofocused "Range Starting Number" inputVerification
pnpm lint,pnpm tscheck,pnpm test(186/186) pass