Strange Image Issues

[t0815]

Before submitting your issue, please verify the following.

• You're using the latest Stable or Daily version of Shoko Server.
• You're using the latest and correct (Stable:Stable, Daily:Daily) Web UI for the version of Shoko you're using.
• You've searched this repository (top of the page) for the issue you are reporting.

Shoko Version

5.3.3

Shoko Version - Daily Commit

No response

Install Type

Windows

Description

I noticed a very strange image management issue. Sometimes, after a show gets updated with updated anidb data, previously downloaded images vanish (get deleted). If you try to update TMDB data, to fetch images again, they keep being deleted. Only if you FORCE update TMDB images again, they reappear.

Example for this is Re:Zero. For some reason only 15 Posters are left for selection. (Max poster download is set to 0), but when checking TMDB there are 186 Posters available. This results in default posters being selected, because the previous selected main-images are somehow no longer present.

Steps to Reproduce

Not 100% sure but:

• go to Show Re:Zero
• Check poster counts
• Update AniDB info
• Previously downloaded Images vanish
• Force update TMDB images, posters reappear and even main-image mapping is still intact

Log File

n/a

Screenshots

No response

[revam]

Image management has been overhauled in daily. So unless you can reproduce the issues on daily under said new management then I don't think it's worth it for us to fix this at the current time, as the current 5.x release branch may not necessarily be the latest stable release by the end of the year. Mayhaps.

[t0815]

Ok, yea makes no sense to invest time - when i have time i will check if i can somehow reproduce with daily build.

[revam]

Half of this is now fixed on master. Every image a provider reports now gets a record, where 5.3.3 only created them for the ones inside your preferred languages, which is where your 15 came from.

The rest isn't there yet. Undownloaded images are still filtered out of the picker by default, and the server only serves what it has on disk. master as of 3d3c179 hands out a source URL for the images it doesn't hold, so a client can display them, though whether the Web UI will use it is yet to be decided. And it still requires sending ?includeUndesired=true on the image endpoint for the undesired images to show up.

The vanishing after an AniDB update I still can't account for from the code, so that's the part worth watching if you do get to testing on daily.