Fix incorrect method signature in Heuristic::Base#call #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The base class declared call(request_time, before_gc_context, after_gc_context) but all concrete implementations use call(request_context). This mismatch could confuse developers implementing custom heuristics.
Nepomuk5665
force-pushed
the
fix-base-class-call-signature
branch
from
dfcea2b to
4c86fce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The abstract
callmethod inHeuristic::Basewas declared as:But all five concrete implementations (Malloc, Oldmalloc, RememberedWBUnprotectedObjects, HeapSizeWarmup, GCCompact) use:
This mismatch in the base class could mislead developers who want to implement custom heuristics, as they might follow the incorrect signature from the base class.
Solution
Updated the base class signature to match the actual implementation:
def call(request_context)