Update redirect logic in theme.liquid to support query params in the storefront_hostname config property#19
Merged
calirvine merged 1 commit intovibe-redirect-themefrom Oct 14, 2025
Conversation
tizmagik
reviewed
Oct 14, 2025
…storefront_hostname config property
calirvine
force-pushed
the
lovable-redirect-theme
branch
from
3663768 to
668915a
Compare
|
Let's have this PR go into a branch off of main instead of to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Some partner platforms redirect includes a query param in the hostname property, but the current implementation does a simple string replace of the current hostname to the new with a path appended. Because it is in the query params section the path is simply appended to the last query parameter which is then not recognized by lovable.
Solution
Create URLs from the original URL + the storefront hostname and modify only targeted properties of each.