Add favicon setting to redirect theme for Shopify checkout#21
Open
quentinlagache wants to merge 1 commit intoShopify:mainfrom
Open
Add favicon setting to redirect theme for Shopify checkout#21quentinlagache wants to merge 1 commit intoShopify:mainfrom
quentinlagache wants to merge 1 commit intoShopify:mainfrom
Conversation
Author
|
Tagging you @benjaminsehl since I can’t add you as a reviewer—could you take a look when you have a moment? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shopify Checkout automatically uses the favicon configured in a theme’s settings. This is implicit/undocumented behavior, but it affects the favicon shown at checkout.
This PR adds the missing favicon setting to the redirect theme so we can set a custom favicon and maintain trust + visual continuity when users are redirected from the Hydrogen storefront to Checkout.