Inline base image into Dockerfile to fix Node 20 requirement#108
Merged
Conversation
Shopify CLI 3.93+ requires Node >=20.10.0 (fixes #103). Rather than maintaining a separate base image on a container registry, this inlines everything into a single Dockerfile. Changes: - Dockerfile now includes all dependencies (Node 20, Chrome, Ruby, Puppeteer, LHCI, Shopify CLI) - Removed Dockerfile.base and build-base-image.yml workflow - Simplified Makefile for local development GitHub Actions caches Docker layers per-repo, so after the first run the build is fast. This avoids the need for registry permissions (ghcr.io, Docker Hub) entirely. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
6e881da to
bf941aa
Compare
charlespwd
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #103. Shopify CLI 3.93+ requires Node >=20.10.0 (
engine-strict: true), which breaks the action since the base Docker image used Node 18.Rather than maintaining a separate base image on a container registry (which requires org-level permissions we couldn't obtain for ghcr.io), this inlines everything into a single Dockerfile.
Changes
Performance
GitHub Actions caches Docker layers per-repo, so:
This avoids the need for any container registry (ghcr.io, Docker Hub) entirely.
Supersedes
This replaces the approach in #105 and #106 which attempted to use ghcr.io.
🎩 Tophatting
This is infrastructure-only (Docker build), so CI passing is the primary verification.
check_dawnjobs exercise the action end-to-end)