Feat/recharts poc#500
Closed
Shramkoweb wants to merge 22 commits into
Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reached
More reviews will be available in 16 minutes and 50 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (19)
📝 WalkthroughWalkthroughThis PR introduces a complete Recharts proof-of-concept (POC) with five chart types, a KPI metrics system, a sortable breakdown table, color theming, and mock data, all deployed at ChangesRecharts POC Feature
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Lighthouse Results
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
components/recharts-poc/table/BreakdownTable.tsx (1)
121-127: ReplaceReact.ReactNodewith an importedReactNodetype.
@types/reactexposes a globalReactnamespace (export as namespace React), so this often compiles as-is; importingReactNoderemoves reliance on that global namespace and makes the type usage more explicit.Proposed fix
-import { useMemo, useState } from 'react'; +import { useMemo, useState } from 'react'; +import type { ReactNode } from 'react'; @@ interface ThProps { onClick: () => void; active: boolean; dir: SortDir; align?: 'left' | 'right'; - children: React.ReactNode; + children: ReactNode; }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@components/recharts-poc/table/BreakdownTable.tsx` around lines 121 - 127, Update the ThProps interface to stop relying on the global React namespace: import the ReactNode type from 'react' (e.g., add `import { ReactNode } from 'react'`) and change the children property type in the ThProps interface from `React.ReactNode` to `ReactNode`; this makes the type explicit and avoids the ambient global `React` namespace dependency (locate the ThProps interface in BreakdownTable.tsx).Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@components/recharts-poc/primitives/periodOverPeriod.test.ts`:
- Around line 28-50: Add a test to cover the missing edge case where previous
=== 0 and current is negative: call periodOverPeriod(-50, 0) and assert it
returns absDelta: -50, pctDelta: null, and direction: 'down'. Place the new
it(...) alongside the other tests in periodOverPeriod.spec (or
periodOverPeriod.test.ts) near the existing cases so the behavior in the
periodOverPeriod(...) function is validated for negative current with zero
previous.
In `@components/recharts-poc/primitives/periodOverPeriod.ts`:
- Around line 11-16: The branch handling previous === 0 currently assigns
direction as current > 0 ? 'up' : 'flat', which treats negative currents as
flat; update the logic inside the function that computes
absDelta/pctDelta/direction (the block referencing previous, current, absDelta,
pctDelta, direction) so that direction is 'up' for current > 0, 'down' for
current < 0, and 'flat' only for current === 0 (e.g. change the ternary to check
current < 0 separately).
---
Nitpick comments:
In `@components/recharts-poc/table/BreakdownTable.tsx`:
- Around line 121-127: Update the ThProps interface to stop relying on the
global React namespace: import the ReactNode type from 'react' (e.g., add
`import { ReactNode } from 'react'`) and change the children property type in
the ThProps interface from `React.ReactNode` to `ReactNode`; this makes the type
explicit and avoids the ambient global `React` namespace dependency (locate the
ThProps interface in BreakdownTable.tsx).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: f0acf64c-1f5f-4119-94e1-269a9963f57c
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (28)
components/recharts-poc/RechartsPocPage.tsxcomponents/recharts-poc/charts/BarChartCard.tsxcomponents/recharts-poc/charts/DonutCard.tsxcomponents/recharts-poc/charts/DualAxisChartCard.tsxcomponents/recharts-poc/charts/HistogramCard.tsxcomponents/recharts-poc/charts/LineChartCard.tsxcomponents/recharts-poc/index.tscomponents/recharts-poc/kpi/DeltaBadge.tsxcomponents/recharts-poc/kpi/KpiCard.tsxcomponents/recharts-poc/mocks/devicePerformance.tscomponents/recharts-poc/mocks/improvedKeywords.tscomponents/recharts-poc/mocks/keywordLength.tscomponents/recharts-poc/mocks/keywords.tscomponents/recharts-poc/mocks/kpis.tscomponents/recharts-poc/mocks/salesAsp.tscomponents/recharts-poc/primitives/ChartCard.tsxcomponents/recharts-poc/primitives/LabelsToggle.tsxcomponents/recharts-poc/primitives/colors.test.tscomponents/recharts-poc/primitives/colors.tscomponents/recharts-poc/primitives/periodOverPeriod.test.tscomponents/recharts-poc/primitives/periodOverPeriod.tscomponents/recharts-poc/primitives/useIsMounted.tscomponents/recharts-poc/table/BreakdownTable.tsxdocs/recharts-poc-report.mdjest.config.jsnext-sitemap.config.cjspackage.jsonpages/labs/recharts.tsx
Comment on lines
+28
to
+50
| it('handles previous === 0 by returning null pctDelta and up direction when current > 0', () => { | ||
| expect(periodOverPeriod(50, 0)).toEqual({ | ||
| absDelta: 50, | ||
| pctDelta: null, | ||
| direction: 'up', | ||
| }); | ||
| }); | ||
|
|
||
| it('handles current === 0 and previous > 0 with -100% delta and down direction', () => { | ||
| expect(periodOverPeriod(0, 100)).toEqual({ | ||
| absDelta: -100, | ||
| pctDelta: -100, | ||
| direction: 'down', | ||
| }); | ||
| }); | ||
|
|
||
| it('handles both zero by returning flat with null pct', () => { | ||
| expect(periodOverPeriod(0, 0)).toEqual({ | ||
| absDelta: 0, | ||
| pctDelta: null, | ||
| direction: 'flat', | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Add a test for previous === 0 and negative current.
Current suite misses the periodOverPeriod(-50, 0) case, which should assert direction: 'down' and would guard this edge branch.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@components/recharts-poc/primitives/periodOverPeriod.test.ts` around lines 28
- 50, Add a test to cover the missing edge case where previous === 0 and current
is negative: call periodOverPeriod(-50, 0) and assert it returns absDelta: -50,
pctDelta: null, and direction: 'down'. Place the new it(...) alongside the other
tests in periodOverPeriod.spec (or periodOverPeriod.test.ts) near the existing
cases so the behavior in the periodOverPeriod(...) function is validated for
negative current with zero previous.
Comment on lines
+11
to
+16
| if (previous === 0) { | ||
| return { | ||
| absDelta, | ||
| pctDelta: null, | ||
| direction: current > 0 ? 'up' : 'flat', | ||
| }; |
There was a problem hiding this comment.
Handle negative current when previous === 0 correctly.
Line 15 currently maps all non-positive values to flat; current < 0 should return down.
Suggested fix
if (previous === 0) {
return {
absDelta,
pctDelta: null,
- direction: current > 0 ? 'up' : 'flat',
+ direction: current > 0 ? 'up' : current < 0 ? 'down' : 'flat',
};
}🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@components/recharts-poc/primitives/periodOverPeriod.ts` around lines 11 - 16,
The branch handling previous === 0 currently assigns direction as current > 0 ?
'up' : 'flat', which treats negative currents as flat; update the logic inside
the function that computes absDelta/pctDelta/direction (the block referencing
previous, current, absDelta, pctDelta, direction) so that direction is 'up' for
current > 0, 'down' for current < 0, and 'flat' only for current === 0 (e.g.
change the ternary to check current < 0 separately).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Chores