Skip to content

fix(chat): use authenticated session identity for sendMessage username [NSoC'26] #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anshul23102 wants to merge 1 commit into
base: master
Choose a base branch
from
+12 −30
Open

fix(chat): use authenticated session identity for sendMessage username [NSoC'26] #164

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 12 additions & 30 deletions backend/controllers/chat.controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,35 +17,17 @@ export const getMessages = async (req, res) => {

export const sendMessage = async (req, res) => {
try {
const { text, username, image, audio } = req.body;

console.log("Incoming:", {
text,
username,
image,
audio,
});

const authHeader = req.headers.authorization;

if (!authHeader?.startsWith("Bearer ")) {
return res.status(401).json({
error: "Authentication required",
});
}

const token = authHeader.split(" ")[1];

const {
data: { user },
error: authError,
} = await supabase.auth.getUser(token);

if (authError || !user) {
return res.status(403).json({
error: "Unauthorized user",
});
}
const { text, image, audio } = req.body;

// Derive username from the authenticated session instead of trusting the
// request body. The route requires authenticateUser, so req.user is always
// set at this point. Accepting username from the body allowed any
// authenticated caller to impersonate a different user by supplying an
// arbitrary username value.
const username = req.user?.user_metadata?.username
|| req.user?.user_metadata?.name
|| req.user?.email
|| "Anonymous";

const validationError = validateMessagePayload({
text,
Expand All @@ -64,7 +46,7 @@ export const sendMessage = async (req, res) => {
.insert([
{
text,
username: user.email || username,
username,
image,
audio,
status: "sent",
Expand Down
Loading