Skip to content

refactor: optimize analytics data preparation #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ash1shkumar wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor: optimize analytics data preparation #223

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 46 additions & 4 deletions frontend/app/components/analytics-comp/MemberAnalytics.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,51 @@ type MemberAnalyticsProps = {
onSelectMember: (memberId: string) => void;
};

function getCompletionRate(
completed: number,
assigned: number
) {
return assigned > 0
? Math.round((completed / assigned) * 100)
: 0;
}

function getReviewLoad(
reviews: number
) {
return Math.min(100, reviews * 4);
}

export default function MemberAnalytics({
members,
selectedMember,
onSelectMember,
}: MemberAnalyticsProps) {
const completionRate = Math.round((selectedMember.completed / selectedMember.assigned) * 100);
const reviewLoad = Math.min(100, selectedMember.reviews * 4);
const otherPercent = 100 - completionRate;
const analyticsMetrics = useMemo(
() => {
const completionRate =
getCompletionRate(
selectedMember.completed,
selectedMember.assigned
);

return {
completionRate,
reviewLoad: getReviewLoad(
selectedMember.reviews
),
otherPercent:
100 - completionRate,
};
},
[selectedMember]
);

const {
completionRate,
reviewLoad,
otherPercent,
} = analyticsMetrics;

return (
<section className="grid grid-cols-1 gap-gutter lg:grid-cols-[minmax(0,1fr)_320px]">
Expand Down Expand Up @@ -110,7 +147,12 @@ export default function MemberAnalytics({
>
<div className="flex items-center justify-between gap-3">
<span className="font-label-md">{member.name}</span>
<span className="text-xs">{Math.round((member.completed / member.assigned) * 100)}%</span>
<span className="text-xs">
{getCompletionRate(
member.completed,
member.assigned
)}%
</span>
</div>
<p className="mt-1 text-xs opacity-75">{member.role}</p>
</button>
Expand Down
Loading