centralize sidebar layout state#224
Open
ash1shkumar wants to merge 1 commit into
Open
Conversation
|
@ash1shkumar is attempting to deploy a commit to the shreemp194-gmailcom's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
👋 Thank you for opening this pull request! I will review your changes and assist you soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR improves sidebar and layout state coordination by centralizing route-derived UI state into a reusable layout state helper. Previously, multiple sidebar visibility and layout conditions were derived directly within the component, making future navigation-related enhancements more difficult to maintain.
The updated implementation introduces a dedicated layout state computation flow and memoizes derived values to reduce unnecessary recalculations during navigation changes.
Key Improvements
useMemoImpact
This refactor improves consistency across sidebar interactions while reducing maintenance complexity. The centralized layout state approach makes future navigation, workspace, and sidebar integrations easier to implement and maintain.
🎯 Type of Change
✅ Testing
Fixes #219
Expected Labels
level3NSoC'26