fix: Subtype make_fuel_dictionary to appropriate types#65
Open
fix: Subtype make_fuel_dictionary to appropriate types#65
make_fuel_dictionary to appropriate types#65Conversation
…for generator retrieval
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
make_fuel_dictionary to appropriate types
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65 +/- ##
==========================================
+ Coverage 88.04% 88.05% +0.01%
==========================================
Files 7 7
Lines 669 670 +1
==========================================
+ Hits 589 590 +1
Misses 80 80
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR - I understand this to be a matter of trying to get production variable data from
PSY.StaticInjectiontypes but these are much broader than generators/storage/load.Would appreciate further review from @jd-lara @acostarelli @GabrielKS
@PabloBotinGP - here is the PR discussed.
This should address: Sienna-Platform/PowerGraphics.jl#132
This pull request shrinks the types of components considered in the
make_fuel_dictionaryfunction and adds a test to ensure the filter function is correctly applied to all relevant component types to make the fuel dictionary. The main changes are:Enhancements to Component Handling:
make_fuel_dictionaryinsrc/fuel_results.jlto considerStaticLoad,Generator, andStoragecomponents, instead of onlyStaticInjection, when filtering system components.Testing Improvements:
test/test_result_sorting.jlto verify that thefilter_funcargument inmake_fuel_dictionaryis applied correctly to all relevant component types, including the addition of aStoragecomponent and checks for empty and single-component results.