Skip to content

fix: Subtype make_fuel_dictionary to appropriate types#65

Open
jarry7 wants to merge 4 commits intomainfrom
jw/fix_make_fuel_dictionary
Open

fix: Subtype make_fuel_dictionary to appropriate types#65
jarry7 wants to merge 4 commits intomainfrom
jw/fix_make_fuel_dictionary

Conversation

@jarry7
Copy link
Copy Markdown
Collaborator

@jarry7 jarry7 commented Apr 13, 2026

TL;DR - I understand this to be a matter of trying to get production variable data from PSY.StaticInjection types but these are much broader than generators/storage/load.

Would appreciate further review from @jd-lara @acostarelli @GabrielKS

@PabloBotinGP - here is the PR discussed.

This should address: Sienna-Platform/PowerGraphics.jl#132

This pull request shrinks the types of components considered in the make_fuel_dictionary function and adds a test to ensure the filter function is correctly applied to all relevant component types to make the fuel dictionary. The main changes are:

Enhancements to Component Handling:

  • Updated make_fuel_dictionary in src/fuel_results.jl to consider StaticLoad, Generator, and Storage components, instead of only StaticInjection, when filtering system components.

Testing Improvements:

  • Added a new test set in test/test_result_sorting.jl to verify that the filter_func argument in make_fuel_dictionary is applied correctly to all relevant component types, including the addition of a Storage component and checks for empty and single-component results.

jarry7 and others added 4 commits April 11, 2026 14:02
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@jarry7 jarry7 requested review from GabrielKS and jd-lara April 13, 2026 22:13
@jarry7 jarry7 changed the title Jw/fix make fuel dictionary fix: jw/fix make fuel dictionary Apr 13, 2026
@jarry7 jarry7 changed the title fix: jw/fix make fuel dictionary fix: Subtype make_fuel_dictionary to appropriate types Apr 13, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.05%. Comparing base (a48ce53) to head (d2c7853).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #65      +/-   ##
==========================================
+ Coverage   88.04%   88.05%   +0.01%     
==========================================
  Files           7        7              
  Lines         669      670       +1     
==========================================
+ Hits          589      590       +1     
  Misses         80       80              
Flag Coverage Δ
unittests 88.05% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant