Port hybrid systems by acostarelli · Pull Request #104 · Sienna-Platform/PowerOperationsModels.jl

acostarelli · 2026-04-30T22:40:10Z

Thanks for opening a PR to PowerOperationsModels.jl, please take note of the following when making a PR:

Check the contributor guidelines

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

JuliaFormatter

[JuliaFormatter] _{reported by reviewdog 🐶}

PowerOperationsModels.jl/src/hybrid_system_models/hybrid_systems.jl

Line 818 in 4ad672f

[JuliaFormatter] _{reported by reviewdog 🐶}

PowerOperationsModels.jl/src/hybrid_system_models/hybrid_systems.jl

Lines 819 to 820 in 4ad672f

    
           con_ub = add_constraints_container!(container, HybridRenewableReserveLimitConstraint, V, names, time_steps; meta = "ub") 
        
           con_lb = add_constraints_container!(container, HybridRenewableReserveLimitConstraint, V, names, time_steps; meta = "lb")

[JuliaFormatter] _{reported by reviewdog 🐶}

PowerOperationsModels.jl/src/hybrid_system_models/hybrid_systems.jl

Line 830 in 4ad672f

    
           mult = get_multiplier_value(HybridRenewableActivePowerTimeSeriesParameter(), d, get_formulation(model)())

[JuliaFormatter] _{reported by reviewdog 🐶}

PowerOperationsModels.jl/src/hybrid_system_models/hybrid_systems.jl

Line 1297 in 4ad672f

    
           constraint = add_constraints_container!(container, HybridStatusOutOnConstraint, V, names, time_steps)

[JuliaFormatter] _{reported by reviewdog 🐶}

PowerOperationsModels.jl/src/hybrid_system_models/hybrid_systems.jl

Line 1300 in 4ad672f

    
           r_up = has_reserves ? get_expression(container, HybridTotalReserveOutUpExpression, V) : nothing

[JuliaFormatter] _{reported by reviewdog 🐶}

PowerOperationsModels.jl/src/hybrid_system_models/hybrid_systems.jl

Line 1336 in 4ad672f

    
           constraint = add_constraints_container!(container, HybridStatusInOnConstraint, V, names, time_steps)

[JuliaFormatter] _{reported by reviewdog 🐶}

PowerOperationsModels.jl/src/hybrid_system_models/hybrid_systems.jl

Line 1339 in 4ad672f

    
           r_dn = has_reserves ? get_expression(container, HybridTotalReserveInDownExpression, V) : nothing

[JuliaFormatter] _{reported by reviewdog 🐶}

PowerOperationsModels.jl/src/hybrid_system_models/hybrid_systems.jl

Line 1375 in 4ad672f

    
           constraint = add_constraints_container!(container, HybridEnergyAssetBalanceConstraint, V, names, time_steps)

[JuliaFormatter] _{reported by reviewdog 🐶}

PowerOperationsModels.jl/src/hybrid_system_models/hybrid_systems.jl

Lines 1380 to 1390 in 4ad672f

    
           p_th = haskey(IOM.get_variables(container), VariableKey(HybridThermalActivePower, V)) ? 
        
               get_variable(container, HybridThermalActivePower, V) : nothing 
        
           p_re = haskey(IOM.get_variables(container), VariableKey(HybridRenewableActivePower, V)) ? 
        
               get_variable(container, HybridRenewableActivePower, V) : nothing 
        
           p_ch = haskey(IOM.get_variables(container), VariableKey(HybridStorageChargePower, V)) ? 
        
               get_variable(container, HybridStorageChargePower, V) : nothing 
        
           p_ds = haskey(IOM.get_variables(container), VariableKey(HybridStorageDischargePower, V)) ? 
        
               get_variable(container, HybridStorageDischargePower, V) : nothing 
        
           load_param = haskey(IOM.get_parameters(container), ParameterKey(HybridElectricLoadTimeSeriesParameter, V)) ? 
        
               get_parameter_array(container, HybridElectricLoadTimeSeriesParameter, V) : nothing

[JuliaFormatter] _{reported by reviewdog 🐶}

PowerOperationsModels.jl/src/hybrid_system_models/hybrid_systems.jl

Line 1408 in 4ad672f

    
           mult = get_multiplier_value(HybridElectricLoadTimeSeriesParameter(), d, get_formulation(model)())

[JuliaFormatter] _{reported by reviewdog 🐶}

PowerOperationsModels.jl/src/hybrid_system_models/hybrid_systems.jl

Line 1430 in 4ad672f

    
           ) where {V <: PSY.HybridSystem, W <: AbstractHybridFormulationWithReserves, X <: AbstractPowerModel}

[JuliaFormatter] _{reported by reviewdog 🐶}

PowerOperationsModels.jl/src/hybrid_system_models/hybrid_systems.jl

Lines 1442 to 1443 in 4ad672f

    
           constraint = add_constraints_container!(container, HybridReserveAssignmentConstraint, V, names, time_steps; 
        
               meta = "$(s_type)_$s_name")

[JuliaFormatter] _{reported by reviewdog 🐶}

PowerOperationsModels.jl/src/hybrid_system_models/hybrid_systems.jl

Line 1471 in 4ad672f

    
           ) where {V <: PSY.HybridSystem, W <: AbstractHybridFormulationWithReserves, X <: AbstractPowerModel}

[JuliaFormatter] _{reported by reviewdog 🐶}

PowerOperationsModels.jl/src/hybrid_system_models/hybrid_systems.jl

Lines 1483 to 1484 in 4ad672f

    
           constraint = add_constraints_container!(container, HybridReserveBalanceConstraint, V, names, time_steps; 
        
               meta = "$(s_type)_$s_name")

[JuliaFormatter] _{reported by reviewdog 🐶}

PowerOperationsModels.jl/src/hybrid_system_models/hybrid_systems.jl

Line 1492 in 4ad672f

HybridChargingReserveVariable, HybridDischargingReserveVariable)

[JuliaFormatter] _{reported by reviewdog 🐶}

PowerOperationsModels.jl/src/hybrid_system_models/hybrid_systems.jl

Lines 1551 to 1553 in 4ad672f

    
           hybrids_with_thermal   = [d for d in devices_vec if PSY.get_thermal_unit(d) !== nothing] 
        
           hybrids_with_renewable = [d for d in devices_vec if PSY.get_renewable_unit(d) !== nothing] 
        
           hybrids_with_storage   = [d for d in devices_vec if PSY.get_storage(d) !== nothing]

[JuliaFormatter] _{reported by reviewdog 🐶}

PowerOperationsModels.jl/src/hybrid_system_models/hybridsystem_constructor.jl

Line 43 in 4ad672f

HybridTotalReserveInUpExpression, HybridTotalReserveInDownExpression,

[JuliaFormatter] _{reported by reviewdog 🐶}

PowerOperationsModels.jl/src/hybrid_system_models/hybridsystem_constructor.jl

Line 45 in 4ad672f

HybridServedReserveInUpExpression, HybridServedReserveInDownExpression,

[JuliaFormatter] _{reported by reviewdog 🐶}

PowerOperationsModels.jl/src/hybrid_system_models/hybridsystem_constructor.jl

Line 53 in 4ad672f

HybridServedReserveOutUpExpression, HybridServedReserveOutDownExpression)

[JuliaFormatter] _{reported by reviewdog 🐶}

PowerOperationsModels.jl/src/hybrid_system_models/hybridsystem_constructor.jl

Line 59 in 4ad672f

HybridServedReserveInUpExpression, HybridServedReserveInDownExpression)

[JuliaFormatter] _{reported by reviewdog 🐶}

PowerOperationsModels.jl/src/hybrid_system_models/hybridsystem_constructor.jl

Line 82 in 4ad672f

    
           lazy_container_addition!(container, E, T, PSY.get_name.(hybrids_with_storage), time_steps)

[JuliaFormatter] _{reported by reviewdog 🐶}

PowerOperationsModels.jl/src/hybrid_system_models/hybridsystem_constructor.jl

Line 90 in 4ad672f

    
           add_to_expression!(container, E, HybridDischargingReserveVariable, hybrids_with_storage, model)

[JuliaFormatter] _{reported by reviewdog 🐶}

PowerOperationsModels.jl/src/hybrid_system_models/hybridsystem_constructor.jl

Line 96 in 4ad672f

    
           add_to_expression!(container, E, HybridChargingReserveVariable, hybrids_with_storage, model)

[JuliaFormatter] _{reported by reviewdog 🐶}

PowerOperationsModels.jl/src/hybrid_system_models/hybridsystem_constructor.jl

Line 110 in 4ad672f

    
           add_to_expression!(container, TotalReserveOffering, v, hybrids_with_storage, model)

[JuliaFormatter] _{reported by reviewdog 🐶}

PowerOperationsModels.jl/src/hybrid_system_models/hybridsystem_constructor.jl

Lines 132 to 134 in 4ad672f

    
           add_to_expression!(container, ActivePowerBalance, ActivePowerInVariable, devices, model, network_model) 
        
           add_to_expression!(container, ActivePowerBalance, ActivePowerOutVariable, devices, model, network_model) 
        
           add_to_expression!(container, ReactivePowerBalance, ReactivePowerVariable, devices, model, network_model)

[JuliaFormatter] _{reported by reviewdog 🐶}

PowerOperationsModels.jl/src/hybrid_system_models/hybridsystem_constructor.jl

Line 143 in 4ad672f

    
           add_parameters!(container, HybridRenewableActivePowerTimeSeriesParameter, grouped.with_renewable, model)

[JuliaFormatter] _{reported by reviewdog 🐶}

PowerOperationsModels.jl/src/hybrid_system_models/hybridsystem_constructor.jl

Line 153 in 4ad672f

    
           add_parameters!(container, HybridElectricLoadTimeSeriesParameter, grouped.with_load, model)

[JuliaFormatter] _{reported by reviewdog 🐶}

PowerOperationsModels.jl/src/hybrid_system_models/hybridsystem_constructor.jl

Line 178 in 4ad672f

    
           add_constraints!(container, ReactivePowerVariableLimitsConstraint, ReactivePowerVariable,

[JuliaFormatter] _{reported by reviewdog 🐶}

PowerOperationsModels.jl/src/hybrid_system_models/hybridsystem_constructor.jl

Lines 183 to 184 in 4ad672f

    
           add_constraints!(container, HybridStatusInOnConstraint,  devices, model, network_model) 
        
           add_constraints!(container, HybridEnergyAssetBalanceConstraint, devices, model, network_model)

[JuliaFormatter] _{reported by reviewdog 🐶}

PowerOperationsModels.jl/src/hybrid_system_models/hybridsystem_constructor.jl

Line 189 in 4ad672f

    
           add_constraints!(container, HybridThermalReserveLimitConstraint, grouped.with_thermal, model, network_model)

[JuliaFormatter] _{reported by reviewdog 🐶}

PowerOperationsModels.jl/src/hybrid_system_models/hybridsystem_constructor.jl

Lines 191 to 192 in 4ad672f

    
           add_constraints!(container, HybridThermalOnVariableUbConstraint, grouped.with_thermal, model, network_model) 
        
           add_constraints!(container, HybridThermalOnVariableLbConstraint, grouped.with_thermal, model, network_model)

[JuliaFormatter] _{reported by reviewdog 🐶}

PowerOperationsModels.jl/src/hybrid_system_models/hybridsystem_constructor.jl

Line 198 in 4ad672f

    
           add_constraints!(container, HybridRenewableActivePowerLimitConstraint, grouped.with_renewable, model, network_model)

[JuliaFormatter] _{reported by reviewdog 🐶}

PowerOperationsModels.jl/src/hybrid_system_models/hybridsystem_constructor.jl

Line 200 in 4ad672f

    
           add_constraints!(container, HybridRenewableReserveLimitConstraint, grouped.with_renewable, model, network_model)

[JuliaFormatter] _{reported by reviewdog 🐶}

PowerOperationsModels.jl/src/hybrid_system_models/hybridsystem_constructor.jl

Line 206 in 4ad672f

    
           add_constraints!(container, HybridStorageBalanceConstraint, grouped.with_storage, model, network_model)

[JuliaFormatter] _{reported by reviewdog 🐶}

PowerOperationsModels.jl/src/hybrid_system_models/hybridsystem_constructor.jl

Line 208 in 4ad672f

    
           add_constraints!(container, StateofChargeTargetConstraint, grouped.with_storage, model, network_model)

[JuliaFormatter] _{reported by reviewdog 🐶}

PowerOperationsModels.jl/src/hybrid_system_models/hybridsystem_constructor.jl

Lines 211 to 214 in 4ad672f

    
           add_constraints!(container, ReserveCoverageConstraint, grouped.with_storage, model, network_model) 
        
           add_constraints!(container, ReserveCoverageConstraintEndOfPeriod, grouped.with_storage, model, network_model) 
        
           add_constraints!(container, HybridStorageChargingReservePowerLimitConstraint, grouped.with_storage, model, network_model) 
        
           add_constraints!(container, HybridStorageDischargingReservePowerLimitConstraint, grouped.with_storage, model, network_model)

[JuliaFormatter] _{reported by reviewdog 🐶}

PowerOperationsModels.jl/src/hybrid_system_models/hybridsystem_constructor.jl

Lines 216 to 217 in 4ad672f

    
           add_constraints!(container, HybridStorageStatusChargeOnConstraint, grouped.with_storage, model, network_model) 
        
           add_constraints!(container, HybridStorageStatusDischargeOnConstraint, grouped.with_storage, model, network_model)

[JuliaFormatter] _{reported by reviewdog 🐶}

PowerOperationsModels.jl/src/hybrid_system_models/hybridsystem_constructor.jl

Lines 223 to 224 in 4ad672f

    
           add_constraints!(container, HybridReserveAssignmentConstraint, devices, model, network_model) 
        
           add_constraints!(container, HybridReserveBalanceConstraint, devices, model, network_model)

[JuliaFormatter] _{reported by reviewdog 🐶}

PowerOperationsModels.jl/src/hybrid_system_models/hybridsystem_constructor.jl

Line 244 in 4ad672f

    
           ) where {T <: PSY.HybridSystem, D <: HybridDispatchWithReserves, S <: AbstractActivePowerModel}

[JuliaFormatter] _{reported by reviewdog 🐶}

PowerOperationsModels.jl/src/hybrid_system_models/hybridsystem_constructor.jl

Lines 252 to 253 in 4ad672f

    
           add_to_expression!(container, ActivePowerBalance, ActivePowerInVariable, devices, model, network_model) 
        
           add_to_expression!(container, ActivePowerBalance, ActivePowerOutVariable, devices, model, network_model)

[JuliaFormatter] _{reported by reviewdog 🐶}

PowerOperationsModels.jl/src/hybrid_system_models/hybridsystem_constructor.jl

Line 261 in 4ad672f

    
           add_parameters!(container, HybridRenewableActivePowerTimeSeriesParameter, grouped.with_renewable, model)

[JuliaFormatter] _{reported by reviewdog 🐶}

PowerOperationsModels.jl/src/hybrid_system_models/hybridsystem_constructor.jl

Line 271 in 4ad672f

    
           add_parameters!(container, HybridElectricLoadTimeSeriesParameter, grouped.with_load, model)

[JuliaFormatter] _{reported by reviewdog 🐶}

PowerOperationsModels.jl/src/hybrid_system_models/hybridsystem_constructor.jl

Line 291 in 4ad672f

    
           ) where {T <: PSY.HybridSystem, D <: HybridDispatchWithReserves, S <: AbstractActivePowerModel}

[JuliaFormatter] _{reported by reviewdog 🐶}

PowerOperationsModels.jl/src/hybrid_system_models/hybridsystem_constructor.jl

Lines 296 to 297 in 4ad672f

    
           add_constraints!(container, HybridStatusInOnConstraint,  devices, model, network_model) 
        
           add_constraints!(container, HybridEnergyAssetBalanceConstraint, devices, model, network_model)

[JuliaFormatter] _{reported by reviewdog 🐶}

PowerOperationsModels.jl/src/hybrid_system_models/hybridsystem_constructor.jl

Line 301 in 4ad672f

    
           add_constraints!(container, HybridThermalReserveLimitConstraint, grouped.with_thermal, model, network_model)

[JuliaFormatter] _{reported by reviewdog 🐶}

PowerOperationsModels.jl/src/hybrid_system_models/hybridsystem_constructor.jl

Lines 303 to 304 in 4ad672f

    
           add_constraints!(container, HybridThermalOnVariableUbConstraint, grouped.with_thermal, model, network_model) 
        
           add_constraints!(container, HybridThermalOnVariableLbConstraint, grouped.with_thermal, model, network_model)

[JuliaFormatter] _{reported by reviewdog 🐶}

PowerOperationsModels.jl/src/hybrid_system_models/hybridsystem_constructor.jl

Line 309 in 4ad672f

    
           add_constraints!(container, HybridRenewableActivePowerLimitConstraint, grouped.with_renewable, model, network_model)

[JuliaFormatter] _{reported by reviewdog 🐶}

PowerOperationsModels.jl/src/hybrid_system_models/hybridsystem_constructor.jl

Line 311 in 4ad672f

    
           add_constraints!(container, HybridRenewableReserveLimitConstraint, grouped.with_renewable, model, network_model)

[JuliaFormatter] _{reported by reviewdog 🐶}

PowerOperationsModels.jl/src/hybrid_system_models/hybridsystem_constructor.jl

Line 316 in 4ad672f

    
           add_constraints!(container, HybridStorageBalanceConstraint, grouped.with_storage, model, network_model)

[JuliaFormatter] _{reported by reviewdog 🐶}

PowerOperationsModels.jl/src/hybrid_system_models/hybridsystem_constructor.jl

Line 318 in 4ad672f

    
           add_constraints!(container, StateofChargeTargetConstraint, grouped.with_storage, model, network_model)

[JuliaFormatter] _{reported by reviewdog 🐶}

PowerOperationsModels.jl/src/hybrid_system_models/hybridsystem_constructor.jl

Lines 321 to 324 in 4ad672f

    
           add_constraints!(container, ReserveCoverageConstraint, grouped.with_storage, model, network_model) 
        
           add_constraints!(container, ReserveCoverageConstraintEndOfPeriod, grouped.with_storage, model, network_model) 
        
           add_constraints!(container, HybridStorageChargingReservePowerLimitConstraint, grouped.with_storage, model, network_model) 
        
           add_constraints!(container, HybridStorageDischargingReservePowerLimitConstraint, grouped.with_storage, model, network_model)

[JuliaFormatter] _{reported by reviewdog 🐶}

PowerOperationsModels.jl/src/hybrid_system_models/hybridsystem_constructor.jl

Lines 326 to 327 in 4ad672f

    
           add_constraints!(container, HybridStorageStatusChargeOnConstraint, grouped.with_storage, model, network_model) 
        
           add_constraints!(container, HybridStorageStatusDischargeOnConstraint, grouped.with_storage, model, network_model)

[JuliaFormatter] _{reported by reviewdog 🐶}

PowerOperationsModels.jl/src/hybrid_system_models/hybridsystem_constructor.jl

Lines 332 to 333 in 4ad672f

    
           add_constraints!(container, HybridReserveAssignmentConstraint, devices, model, network_model) 
        
           add_constraints!(container, HybridReserveBalanceConstraint, devices, model, network_model)

github-actions · 2026-04-30T23:11:39Z

Performance Results

Version	Precompile Time
Main	2.791720029
This Branch	2.780480675

Version	Build Time
Main-Build Time Precompile	93.139721003
Main-Build Time Postcompile	14.936840596
This Branch-Build Time Precompile	93.293282646
This Branch-Build Time Postcompile	14.881578305

Version	Solve Time
Main-Solve Time Precompile	409.538186946
Main-Solve Time Postcompile	378.418116699
This Branch-Solve Time Precompile	169.564918863
This Branch-Solve Time Postcompile	138.487782779

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

JuliaFormatter

[JuliaFormatter] _{reported by reviewdog 🐶}

PowerOperationsModels.jl/src/hybrid_system_models/hybridsystem_constructor.jl

Lines 143 to 144 in e0d67dc

    
           add_to_expression!(container, ActivePowerBalance, ActivePowerInVariable, devices, model, network_model) 
        
           add_to_expression!(container, ActivePowerBalance, ActivePowerOutVariable, devices, model, network_model)

[JuliaFormatter] _{reported by reviewdog 🐶}

PowerOperationsModels.jl/src/hybrid_system_models/hybridsystem_constructor.jl

Line 154 in e0d67dc

    
           add_parameters!(container, HybridRenewableActivePowerTimeSeriesParameter, grouped.with_renewable, model)

[JuliaFormatter] _{reported by reviewdog 🐶}

PowerOperationsModels.jl/src/hybrid_system_models/hybridsystem_constructor.jl

Line 164 in e0d67dc

    
           add_parameters!(container, HybridElectricLoadTimeSeriesParameter, grouped.with_load, model)

[JuliaFormatter] _{reported by reviewdog 🐶}

PowerOperationsModels.jl/src/hybrid_system_models/hybridsystem_constructor.jl

Lines 193 to 194 in e0d67dc

    
           add_constraints!(container, HybridStatusInOnConstraint,  devices, model, network_model) 
        
           add_constraints!(container, HybridEnergyAssetBalanceConstraint, devices, model, network_model)

[JuliaFormatter] _{reported by reviewdog 🐶}

PowerOperationsModels.jl/src/hybrid_system_models/hybridsystem_constructor.jl

Line 199 in e0d67dc

    
           add_constraints!(container, HybridThermalReserveLimitConstraint, grouped.with_thermal, model, network_model)

[JuliaFormatter] _{reported by reviewdog 🐶}

PowerOperationsModels.jl/src/hybrid_system_models/hybridsystem_constructor.jl

Lines 201 to 202 in e0d67dc

    
           add_constraints!(container, HybridThermalOnVariableUbConstraint, grouped.with_thermal, model, network_model) 
        
           add_constraints!(container, HybridThermalOnVariableLbConstraint, grouped.with_thermal, model, network_model)

[JuliaFormatter] _{reported by reviewdog 🐶}

PowerOperationsModels.jl/src/hybrid_system_models/hybridsystem_constructor.jl

Line 208 in e0d67dc

    
           add_constraints!(container, HybridRenewableActivePowerLimitConstraint, grouped.with_renewable, model, network_model)

[JuliaFormatter] _{reported by reviewdog 🐶}

PowerOperationsModels.jl/src/hybrid_system_models/hybridsystem_constructor.jl

Line 210 in e0d67dc

    
           add_constraints!(container, HybridRenewableReserveLimitConstraint, grouped.with_renewable, model, network_model)

[JuliaFormatter] _{reported by reviewdog 🐶}

PowerOperationsModels.jl/src/hybrid_system_models/hybridsystem_constructor.jl

Line 216 in e0d67dc

    
           add_constraints!(container, HybridStorageBalanceConstraint, grouped.with_storage, model, network_model)

[JuliaFormatter] _{reported by reviewdog 🐶}

PowerOperationsModels.jl/src/hybrid_system_models/hybridsystem_constructor.jl

Line 218 in e0d67dc

    
           add_constraints!(container, StateofChargeTargetConstraint, grouped.with_storage, model, network_model)

[JuliaFormatter] _{reported by reviewdog 🐶}

PowerOperationsModels.jl/src/hybrid_system_models/hybridsystem_constructor.jl

Lines 221 to 224 in e0d67dc

    
           add_constraints!(container, ReserveCoverageConstraint, grouped.with_storage, model, network_model) 
        
           add_constraints!(container, ReserveCoverageConstraintEndOfPeriod, grouped.with_storage, model, network_model) 
        
           add_constraints!(container, HybridStorageChargingReservePowerLimitConstraint, grouped.with_storage, model, network_model) 
        
           add_constraints!(container, HybridStorageDischargingReservePowerLimitConstraint, grouped.with_storage, model, network_model)

[JuliaFormatter] _{reported by reviewdog 🐶}

PowerOperationsModels.jl/src/hybrid_system_models/hybridsystem_constructor.jl

Lines 226 to 227 in e0d67dc

    
           add_constraints!(container, HybridStorageStatusChargeOnConstraint, grouped.with_storage, model, network_model) 
        
           add_constraints!(container, HybridStorageStatusDischargeOnConstraint, grouped.with_storage, model, network_model)

[JuliaFormatter] _{reported by reviewdog 🐶}

PowerOperationsModels.jl/src/hybrid_system_models/hybridsystem_constructor.jl

Lines 233 to 234 in e0d67dc

    
           add_constraints!(container, HybridReserveAssignmentConstraint, devices, model, network_model) 
        
           add_constraints!(container, HybridReserveBalanceConstraint, devices, model, network_model)

rodrigomha

We need to add a couple of extra tests.

First, we need to test different attributes, that is using reservation = false, and energy target = true. Also, what happened with storage_reservation and regularization attributes?

Also, it would be good to test that the hybrid system builds when there is no thermal, or no storage, or no renewable.

Finally, it would be good to test when the hybrid does not participate in reserves.

Overall, the PR looks good. Once we have the tests, I will QA/QC the model for the different tests to ensure that the constraints are looking good.

rodrigomha · 2026-05-05T07:29:57Z

@@ -0,0 +1,1828 @@
+#! format: off


I think we can enable format on every line here. The methods are quite large and probably need format anyways

kdayday · 2026-05-05T16:51:19Z

+# Hybrid System Parameters
+#################################################################################
+
+"Time-series parameter for the maximum active power available from a hybrid system's


@jd-lara This is a change from how things are currently defined in HSS with the time series attached to the hybrid, not the subcomponent, but I guess that works and is simpler for this case?

kdayday

Following Rodrigo's lead on the testing, but in addition, can you port over the updated equivalent of what's in the HybridDispatchWithReserves docstring on the HSS PR and have claude add hyperlinks to exported types and functions referenced in the docstring? It looks like the POM docs are way out of date, but would like to update as we go.

Copilot

Pull request overview

This PR ports/introduces PSY.HybridSystem support into PowerOperationsModels.jl by adding a new HybridDispatchWithReserves device formulation, its constructor plumbing, and a basic end-to-end test that builds/solves a hybrid co-optimization on RTS-GMLC.

Changes:

Adds hybrid formulation types, variables/parameters/expressions/constraints, and objective plumbing for HybridDispatchWithReserves.
Adds a two-stage construct_device! implementation for HybridSystems (argument + model stages) and hooks it into the main module includes/exports.
Adds test utilities and a new test that builds and solves a model containing a HybridSystem with reserves.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
`src/PowerOperationsModels.jl`	Includes hybrid model files and exports the new hybrid-related types.
`src/hybrid_system_models/hybrid_systems.jl`	Implements hybrid variable bounds, reserve aggregation, constraints, and objective-cost plumbing.
`src/hybrid_system_models/hybridsystem_constructor.jl`	Adds the two-stage `construct_device!` pipeline for `HybridDispatchWithReserves`.
`src/core/variables.jl`	Introduces HybridSystem-specific variable types.
`src/core/parameters.jl`	Introduces HybridSystem time-series parameter types and unit-conversion behavior.
`src/core/expressions.jl`	Adds HybridSystem reserve aggregation/served-reserve expression types.
`src/core/constraints.jl`	Adds HybridSystem constraint type definitions.
`src/core/formulations.jl`	Adds hybrid formulation types and user-facing documentation.
`test/test_utils/hybrid_test_utils.jl`	Adds fixtures for building a test HybridSystem in RTS-GMLC.
`test/test_device_hybrid_constructors.jl`	Adds an integration-style test that builds and solves a hybrid dispatch-with-reserves model.
`test/includes.jl`	Wires hybrid test utilities into the test suite.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

+        end
+        if load_param_container !== nothing && PSY.get_electric_load(d) !== nothing
+            load_ref = get_parameter_column_refs(load_param_container, name)[t]
+            JuMP.add_to_expression!(rhs, -load_multiplier[name, t], load_ref)


+
+# Disambiguate against the generic ReserveDemandCurve method in services_models/reserves.jl.
+function get_variable_upper_bound(::Type{ActivePowerReserveVariable}, r::PSY.ReserveDemandCurve, d::PSY.HybridSystem, ::Type{<:AbstractReservesFormulation})
+    return PSY.get_output_active_power_limits(d).max + PSY.get_input_active_power_limits(d).max


+    add_variables!(container, ActivePowerOutVariable, devices, D)
+    add_variables!(container, ActivePowerInVariable, devices, D)
+    _maybe_add_reactive_power_variable!(container, devices, D, S)
+    add_variables!(container, ReservationVariable, devices, D)


+    # PCC ↔ subcomponent plumbing
+    add_constraints!(container, HybridStatusOutOnConstraint, devices, model, network_model)
+    add_constraints!(container, HybridStatusInOnConstraint, devices, model, network_model)
+    add_constraints!(


+"""
+Energy asset balance: the hybrid's PCC injection equals the sum of subcomponent
+injections (thermal + renewable + storage discharge - storage charge - load).
+Reserves contribute through their *served* (deployed-fraction) expressions.


+    time_steps = get_time_steps(container)
+    variable = get_variable(container, V, D)
+    for d in devices
+        sub = accessor(d)
+        sub === nothing && continue
+        cost_term = PSY.get_fixed(PSY.get_operation_cost(sub))
+        cost_term == 0.0 && continue
+        name = PSY.get_name(d)
+        for t in time_steps
+            add_to_objective_invariant_expression!(
+                container,
+                cost_term * variable[name, t],
+            )
+        end


+  - `"reservation"`: forces the storage subcomponent to operate exclusively on charge or
+    discharge mode through the entire operation interval.


claude initial

4ad672f

github-actions Bot reviewed Apr 30, 2026

View reviewed changes

Anthony Costarelli added 2 commits May 4, 2026 17:22

fix time-series parameter accessing; fix onparameter cost adding

b36ad3c

simplify constructor

e0d67dc

github-actions Bot reviewed May 5, 2026

View reviewed changes

formatting

e2e7871

acostarelli marked this pull request as ready for review May 5, 2026 02:59

jd-lara requested review from kdayday and rodrigomha May 5, 2026 04:19

rodrigomha requested changes May 5, 2026

View reviewed changes

rodrigomha reviewed May 5, 2026

View reviewed changes

kdayday reviewed May 5, 2026

View reviewed changes

kdayday requested changes May 5, 2026

View reviewed changes

acostarelli requested a review from Copilot May 5, 2026 18:40

Copilot started reviewing on behalf of acostarelli May 5, 2026 18:40 View session

Copilot AI reviewed May 5, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Port hybrid systems#104

Port hybrid systems#104
acostarelli wants to merge 4 commits intomainfrom
ac/hybrid

acostarelli commented Apr 30, 2026

Uh oh!

github-actions Bot left a comment

Uh oh!

github-actions Bot commented Apr 30, 2026 •

edited

Loading

Uh oh!

github-actions Bot left a comment

Uh oh!

rodrigomha left a comment •

edited

Loading

Uh oh!

rodrigomha May 5, 2026

Uh oh!

kdayday May 5, 2026

Uh oh!

kdayday left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	con_ub = add_constraints_container!(container, HybridRenewableReserveLimitConstraint, V, names, time_steps; meta = "ub")
	con_lb = add_constraints_container!(container, HybridRenewableReserveLimitConstraint, V, names, time_steps; meta = "lb")

	p_th = haskey(IOM.get_variables(container), VariableKey(HybridThermalActivePower, V)) ?
	get_variable(container, HybridThermalActivePower, V) : nothing
	p_re = haskey(IOM.get_variables(container), VariableKey(HybridRenewableActivePower, V)) ?
	get_variable(container, HybridRenewableActivePower, V) : nothing
	p_ch = haskey(IOM.get_variables(container), VariableKey(HybridStorageChargePower, V)) ?
	get_variable(container, HybridStorageChargePower, V) : nothing
	p_ds = haskey(IOM.get_variables(container), VariableKey(HybridStorageDischargePower, V)) ?
	get_variable(container, HybridStorageDischargePower, V) : nothing

	load_param = haskey(IOM.get_parameters(container), ParameterKey(HybridElectricLoadTimeSeriesParameter, V)) ?
	get_parameter_array(container, HybridElectricLoadTimeSeriesParameter, V) : nothing

	constraint = add_constraints_container!(container, HybridReserveAssignmentConstraint, V, names, time_steps;
	meta = "$(s_type)_$s_name")

	hybrids_with_thermal = [d for d in devices_vec if PSY.get_thermal_unit(d) !== nothing]
	hybrids_with_renewable = [d for d in devices_vec if PSY.get_renewable_unit(d) !== nothing]
	hybrids_with_storage = [d for d in devices_vec if PSY.get_storage(d) !== nothing]

	add_to_expression!(container, ActivePowerBalance, ActivePowerInVariable, devices, model, network_model)
	add_to_expression!(container, ActivePowerBalance, ActivePowerOutVariable, devices, model, network_model)
	add_to_expression!(container, ReactivePowerBalance, ReactivePowerVariable, devices, model, network_model)

	add_constraints!(container, HybridStatusInOnConstraint, devices, model, network_model)
	add_constraints!(container, HybridEnergyAssetBalanceConstraint, devices, model, network_model)

	add_constraints!(container, HybridThermalOnVariableUbConstraint, grouped.with_thermal, model, network_model)
	add_constraints!(container, HybridThermalOnVariableLbConstraint, grouped.with_thermal, model, network_model)

	add_constraints!(container, ReserveCoverageConstraint, grouped.with_storage, model, network_model)
	add_constraints!(container, ReserveCoverageConstraintEndOfPeriod, grouped.with_storage, model, network_model)
	add_constraints!(container, HybridStorageChargingReservePowerLimitConstraint, grouped.with_storage, model, network_model)
	add_constraints!(container, HybridStorageDischargingReservePowerLimitConstraint, grouped.with_storage, model, network_model)

	add_constraints!(container, HybridReserveAssignmentConstraint, devices, model, network_model)
	add_constraints!(container, HybridReserveBalanceConstraint, devices, model, network_model)

		- `"reservation"`: forces the storage subcomponent to operate exclusively on charge or
		discharge mode through the entire operation interval.

Conversation

acostarelli commented Apr 30, 2026

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

rodrigomha left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rodrigomha May 5, 2026

Choose a reason for hiding this comment

Uh oh!

kdayday May 5, 2026

Choose a reason for hiding this comment

Uh oh!

kdayday left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions Bot commented Apr 30, 2026 •

edited

Loading

rodrigomha left a comment •

edited

Loading