implement native networkmodels by jd-lara · Pull Request #105 · Sienna-Platform/PowerOperationsModels.jl

jd-lara · 2026-05-04T22:34:59Z

This is part 1 of removing the dependency on PowerModels. More testing ideas from what's here already are welcome

jd-lara · 2026-05-04T22:40:29Z

+# by the branch device construction path (Phase F).
+#
+# Convention: variables/constraints indexed by ACBus use bus NAME (String) — see dcp_model.jl.
+# add_variables!(VoltageAngle, ...) for ACPPowerModel is defined in dcp_model.jl


For situation like this use a network_common.jl file

jd-lara · 2026-05-04T22:42:19Z

@@ -0,0 +1,166 @@
+# Native ACP network formulation. Provides bus voltage magnitude + angle


Check that this is tested with systems that contain multiple subnetworks with distinct slack buses

Copilot

Pull request overview

This PR introduces native DCPPowerModel and ACPPowerModel network formulations inside PowerOperationsModels as a first step toward removing the dependency on the PowerModels bridge.

Changes:

Added native DCP/ACP network model types and concrete construct_network! implementations (voltage variables, reference-bus pinning, nodal balances).
Implemented native AC-branch primitives (admittance, flow limits) and native DCP/ACP branch construction paths (variables, Ohm’s law, rate limits, angle-difference limits, 3-winding transformer handling).
Added expression wiring for native ACP directional branch flows and added initial unit tests for new branch primitives.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
`test/test_native_dcp_acp_models.jl`	Adds unit tests for new `branch_admittance` and `branch_flow_limits` primitives.
`test/Project.toml`	Updates test dependency sources (notably points IOM to `main`).
`src/PowerOperationsModels.jl`	Stops importing PM’s `DCPPowerModel`/`ACPPowerModel`, includes native model files, exports new constraint types.
`src/network_models/network_constructor.jl`	Adds native `construct_network!` dispatch for `NetworkModel{DCPPowerModel}` and `NetworkModel{ACPPowerModel}`.
`src/network_models/dcp_model.jl`	Implements native DCP voltage-angle variables, reference bus pinning, and active nodal balance constraints.
`src/network_models/acp_model.jl`	Implements native ACP voltage-magnitude variables, reference bus pinning (vm/va), and active/reactive nodal balances.
`src/core/network_formulations.jl`	Defines native `DCPPowerModel` and `ACPPowerModel` marker structs.
`src/core/constraints.jl`	Introduces `ReferenceBusConstraint` and `AngleDifferenceConstraint` types.
`src/common_models/add_to_expression.jl`	Adds native ACP/DCP HVDC and ACP directional AC-branch flow contributions to nodal balances.
`src/ac_transmission_models/branch_constructor.jl`	Adds native DCP/ACP branch constructor dispatches, HVDC var creation, and Transformer3W-specific dispatches.
`src/ac_transmission_models/AC_branches.jl`	Adds primitives (`branch_admittance`, `branch_flow_limits`) and native DCP/ACP branch constraints (rate limits, Ohm’s law, angle limits, Transformer3W decomposition).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

+        from_bus = PSY.get_number(PSY.get_from(PSY.get_arc(br)))
+        to_bus = PSY.get_number(PSY.get_to(PSY.get_arc(br)))


+    for d in devices
+        name = PSY.get_name(d)
+        adm = branch_admittance(d)
+        from_bus_obj = PSY.get_from(PSY.get_arc(d))
+        to_bus_obj = PSY.get_to(PSY.get_arc(d))
+        from_bus = PSY.get_name(from_bus_obj)
+        to_bus = PSY.get_name(to_bus_obj)


+    time_steps = get_time_steps(container)
+    network_reduction = get_network_reduction(network_model)
+    va = get_variable(container, VoltageAngle, PSY.ACBus)
+
+    branch_names = [PSY.get_name(d) for d in branches_with_limits]
+    cons = add_constraints_container!(
+        container, AngleDifferenceConstraint, T, branch_names, time_steps,
+    )
+
+    for d in branches_with_limits
+        name = PSY.get_name(d)
+        lims = PSY.get_angle_limits(d)
+        from_bus_obj = PSY.get_from(PSY.get_arc(d))
+        to_bus_obj = PSY.get_to(PSY.get_arc(d))
+        from_bus = PSY.get_name(from_bus_obj)
+        to_bus = PSY.get_name(to_bus_obj)
+        for t in time_steps


+        from_bus = PSY.get_name(from_bus_obj)
+        to_bus = PSY.get_name(to_bus_obj)


+        from_bus = PSY.get_name(from_bus_obj)
+        to_bus = PSY.get_name(to_bus_obj)


jd-lara · 2026-05-04T22:43:24Z

+
+    for k in subnet_keys
+        bus_set = subnets[k]
+        ref = _find_reference_bus(sys, bus_set)


This should error earlier in the network model subnets. This code should be already covered in several of the network models checks.

jd-lara · 2026-05-04T22:43:50Z

+        # Skip subnetworks without an AC reference bus (e.g. an isolated DC-side
+        # island connected through HVDC converters).
+        ref === nothing && continue
+        ref_name = ref.name


using dot access is a clear break from the Sienna.md practices. Unacceptable

jd-lara · 2026-05-04T22:45:49Z

+# System-balance expressions (ActivePowerBalance) are indexed by bus NUMBER
+# (Int) per make_system_expressions.jl, so internal lookups translate names↔numbers.
+
+function _bus_name_number_pairs(


This information is also available from the NetworkModel

github-actions · 2026-05-04T23:06:22Z

Performance Results

Version	Precompile Time
Main	2.883917396
This Branch	2.842031289

Version	Build Time
Main-Build Time Precompile	100.858910553
Main-Build Time Postcompile	14.753206866
This Branch-Build Time Precompile	97.451985118
This Branch-Build Time Postcompile	14.902604889

Version	Solve Time
Main-Solve Time Precompile	396.956022132
Main-Solve Time Postcompile	361.815334124
This Branch-Solve Time Precompile	167.668779027
This Branch-Solve Time Postcompile	135.419185484

luke-kiernan

Big picture things:

In my opinion, JuMP calls only belong in POM if they're device-specific or otherwise bespoke. If you're just assigning upper/lower bounds with some slacks, I'd prefer to have the math live back in IOM.
In construct_device! calls, we almost always write

add_variables!(container, FlowActivePowerFromToVariable, devices, StaticBranchBounds)
add_variables!(container, FlowActivePowerToFromVariable, devices, StaticBranchBounds)
add_variables!(container, FlowReactivePowerFromToVariable, devices, StaticBranchBounds)
add_variables!(container, FlowReactivePowerToFromVariable, devices, StaticBranchBounds)

instead of

for flow_var in (FlowActivePowerFromToVariable, ...) # list 4 variable types
    add_variables!(container, flow_var, devices, StaticBranchBounds)
end

Is there a good reason for this pattern? I find the 2nd much easier to parse at a glance

luke-kiernan · 2026-05-05T00:16:03Z

+- `tap`: voltage-ratio magnitude (1.0 if not a tap-changing transformer)
+- `shift`: nominal phase-shift angle in radians (0.0 if not a PST; the value of α for fixed PSTs)
+"""
+function branch_admittance end


Does branch_admittance really belong here in POM? I'd sooner put it in PNM or perhaps even in PSY for the raw components.

luke-kiernan · 2026-05-05T00:21:59Z

+Constrains pft^2 + qft^2 ≤ rating^2.  Does not depend on PTDF / network-reduction
+infrastructure; iterates directly over devices.
+"""
+function add_constraints!(


These next 2 functions only differ by FromTo versus ToFrom. Combine: either multiple dispatch pattern or just separate out the 3 get_variable calls and delegate the last dozen lines to a helper.

luke-kiernan · 2026-05-05T00:28:32Z

+This is a simple lb/ub pair on the FlowActivePowerVariable that does not depend on the
+PTDF / network-reduction infrastructure used by the AbstractActivePowerModel dispatch.
+"""
+function add_constraints!(


There's nothing novel about the types or math here: imo this ought to be calling some IOM function. In the no-slacks case, add_range_constraints! works; we might need to add a variant of add_range_constraints! that allows for slacks.

luke-kiernan · 2026-05-05T00:33:24Z

+(i.e. not the ±π defaults) receive a constraint.  Branches where the method is not defined
+are silently skipped.
+"""
+function add_constraints!(


Looks identical or nearly identical to the DCPPowerModel implementation. Combine.

luke-kiernan · 2026-05-05T00:34:08Z

+Returns a tuple of 3 NamedTuples, one per winding of a Transformer3W:
+  (suffix, arc, r, x, rating, tap, base_power)
+"""
+function _three_winding_arcs(t::PSY.Transformer3W)


_three_winding_arcs and _winding_admittance seem like they belong in PNM or PSY.

luke-kiernan · 2026-05-05T01:01:33Z

+
+# Shared between DCPPowerModel and ACPPowerModel — both put VoltageAngle on every
+# bus axis with no bounds. Slack-bus pinning is applied by ReferenceBusConstraint.
+function add_variables!(


Not needed: looks equivalent to the generic add_variables! implementation in IOM.

edit: might need to define get_variable_binary to be false for that implementation to work.

luke-kiernan · 2026-05-05T01:07:52Z

+    return nothing
+end
+
+function add_constraints!(


Same as above: check IOM for relevant helper functions

luke-kiernan · 2026-05-05T01:10:31Z

+        to_bus = PSY.get_name(to_bus_obj)
+        # Pre-compute constant coefficients from tap + shift.
+        # Convention (same as PowerModels.jl ACP):
+        #   tr = tm * cos(shift),  ti = tm * sin(shift)


Yikes this is complicated. Would be good to get some tests here. Is there a simple way to tell if it's correct via complex number math or numerical approximations?

jd-lara · 2026-05-05T02:52:29Z

@luke-kiernan after a second look this PR needs more work since it isn't leveraging correctly the mappings in NetworkModels. I need to direct Claude better

jd-lara added 7 commits April 30, 2026 10:41

add new constraints

8a2b875

add native DCP and ACP models

51672c3

add AC Branches methods

c814d69

add network types and constructors

1b8e513

add methods for branches expressions

0d2a59f

add testing

a9c8430

fix deps versions

bee4fa0

jd-lara requested review from Copilot, luke-kiernan and m-bossart May 4, 2026 22:34

jd-lara self-assigned this May 4, 2026

Copilot started reviewing on behalf of jd-lara May 4, 2026 22:35 View session

jd-lara commented May 4, 2026

View reviewed changes

Copilot AI reviewed May 4, 2026

View reviewed changes

jd-lara commented May 4, 2026

View reviewed changes

luke-kiernan reviewed May 5, 2026

View reviewed changes

		@@ -0,0 +1,166 @@
		# Native ACP network formulation. Provides bus voltage magnitude + angle

		from_bus = PSY.get_number(PSY.get_from(PSY.get_arc(br)))
		to_bus = PSY.get_number(PSY.get_to(PSY.get_arc(br)))

		from_bus = PSY.get_name(from_bus_obj)
		to_bus = PSY.get_name(to_bus_obj)

Conversation

jd-lara commented May 4, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented May 4, 2026

Uh oh!

luke-kiernan left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jd-lara commented May 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants