Skip to content

feat(combobox): rewrite entire component & add virtual support#251

Open
H4ad wants to merge 4 commits into
mainfrom
feat/combobox-virtual
Open

feat(combobox): rewrite entire component & add virtual support#251
H4ad wants to merge 4 commits into
mainfrom
feat/combobox-virtual

Conversation

@H4ad
Copy link
Copy Markdown
Contributor

@H4ad H4ad commented May 22, 2026

Changes:

  • Bunch of rewrite in the combobox simple component to simplify the code
  • Add extensive testing
  • Improved some default behavior (order of items, dividers being hidden when filter)
  • Added support to virtualization
    • We have some cases on SigNoz that causes the component to behave poorly without virtualization.

@H4ad H4ad requested a review from a team as a code owner May 22, 2026 14:29
@H4ad H4ad force-pushed the feat/combobox-virtual branch 2 times, most recently from e732ec3 to d764972 Compare May 22, 2026 14:58
@H4ad H4ad force-pushed the feat/combobox-virtual branch from d764972 to debb2e8 Compare May 22, 2026 15:06
@YounixM
Copy link
Copy Markdown
Member

YounixM commented May 23, 2026

@H4ad - just want to confirm if the below 2 cases are handled.

  1. Clear selection (without opening the suggestions)
  2. If a group doesn't have any items, is the group title shown or hidden ?

@H4ad
Copy link
Copy Markdown
Contributor Author

H4ad commented May 23, 2026

  1. I didn't added support yet The support was added.
  2. It will be hidden/filtered out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants