feat(input): add new textArea comp#258
Merged
Merged
Conversation
tewarig
commented
May 25, 2026
Comment on lines
+122
to
+131
| const [trackedValue, setTrackedValue] = React.useState<string>(() => | ||
| defaultValue !== undefined && defaultValue !== null ? String(defaultValue) : '' | ||
| ); | ||
|
|
||
| const isControlled = value !== undefined; | ||
| const replicated = isControlled | ||
| ? value === null || value === undefined | ||
| ? '' | ||
| : String(value) | ||
| : trackedValue; |
Member
Author
There was a problem hiding this comment.
we should ideally refactor this to some useControllableState.
tewarig
changed the title
H4ad
requested changes
May 26, 2026
Contributor
H4ad
left a comment
H4ad
left a comment
There was a problem hiding this comment.
Missing textarea.mdx to showcase the component.
H4ad
reviewed
May 28, 2026
| const resolvedRows = autoSizeOn ? (minRows ?? rows ?? 1) : rows; | ||
|
|
||
| return ( | ||
| <div |
Contributor
There was a problem hiding this comment.
Do we really need this wrapper? Would make sense to have the className passed to the wrapper, if I want to change the width of this component, I don't want to pass <TextArea rootClassName
Comment on lines
+1
to
+17
| $sizes: ( | ||
| small: ( | ||
| padding-y: var(--textarea-size-small-padding-y, var(--spacing-2, 0.25rem)), | ||
| font-size: var(--textarea-size-small-font-size, 12px), | ||
| ), | ||
| middle: ( | ||
| padding-y: var(--textarea-size-middle-padding-y, var(--spacing-4, 0.5rem)), | ||
| font-size: var( | ||
| --textarea-size-middle-font-size, | ||
| var(--input-font-size, var(--periscope-font-size-base, 13px)) | ||
| ), | ||
| ), | ||
| large: ( | ||
| padding-y: var(--textarea-size-large-padding-y, var(--spacing-6, 0.75rem)), | ||
| font-size: var(--textarea-size-large-font-size, 14px), | ||
| ), | ||
| ); |
Contributor
There was a problem hiding this comment.
The result on InputNumber looked good, let's do the same here.
Member
Author
|
will raise another pr for this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add new textArea component
Screen.Recording.2026-05-25.at.11.45.31.PM.mov