feat: adds CollectionAgent scaffolding#124
Open
Nageshbansal wants to merge 9 commits into
Open
Conversation
therealpandey
requested changes
May 26, 2026
- domain: add Merge/MergeYAML with a per-path ListMerge strategy (k8s listType) - pourer: add staging buffer a casting fills during Forge - collectormolding: render the base config and merge the enricher's contribution at the kind's config key - api: add TypeConfig.Set and CollectorKind.ConfigKey
Nageshbansal
force-pushed
the
feat/casting/ca/scaffolding
branch
from
e1908d4 to
637a889
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scaffolds the CollectionAgent Kind on the Planner contract from #122. Lands the API types, the agent-kind collector molding, a list-aware config merge primitive, and a shared pourer staging buffer.
Changes
CollectorStatuscarries the collector config as a config map; addsCollectorKind.ConfigKeyandTypeConfig.Set.Castinginterface +Plannerroute Forge/Cast through a*pourer.Pourer.internal/molding/collectionagent/collectormolding/renders the base agent OTel config and merges the enricher's contribution at the kind's config key.internal/pourerpackage: staging buffer that hidesdomain.Materialfrom castings.domain.Merge/domain.MergeYAML: deep-merge with a per-pathListMergestrategy (k8s listType), reusable across moldings.Related: https://github.com/SigNoz/platform-pod/issues/1971, https://github.com/SigNoz/platform-pod/issues/1972