Module 4: Game Library & Discovery backend - #7
Merged
Conversation
Adds Game/GameTag/GameModeCapability/UserFavoriteGame/CatalogSeedHistory entities, EF configurations, two additive migrations, and the checksum-verified seed manifest + advisory-locked seeder CLI for the canonical 8-game catalog.
Wires GamesController (list, detail, featured, favorites) through GamesService/GameRepository with cache/ETag/304 handling, cursor pagination, an outbox for favorite/lifecycle events, and three dedicated rate-limiter policies for catalog reads, search, and favorites.
Unit tests for the Game/UserFavoriteGame domain, GamesService, and cursor codec; integration tests for migrations, the seeder (advisory lock, checksum, rerun idempotency), HTTP contract, and real-Postgres concurrency (favorite races, seed races).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What changed
Game,GameTag,GameModeCapability,UserFavoriteGame,CatalogSeedHistoryentities and EF configurations.AddGameCatalog,AddGameLifecycleVersion), a checksum-verified seed manifest (8 neutral-named games), and an advisory-locked idempotent seeder CLI.GamesController(list/detail/featured/favorites) viaGamesService/GameRepository, cursor pagination, ETag/304, an outbox for favorite/lifecycle events, and 3 dedicated rate-limiter policies.Tests
Security/docs
--security=lightbackend review: zero Critical/High. 2 Low (sort-index gap, favorites-list index gap) + 1 Info (project-wide correlation id), all deferred/non-blocking.SimPle.Project/docs/security/audits/module-04-game-library-discovery.md(companion PR).Risks/deferred
EXPLAIN); bounded by current catalog size and rate limits.UserFavoriteGamehas no row-level concurrency token; conflict detection relies on the outbox's unique index instead (verified correct under real concurrent writers).docs/ai-workflow/evidence/module-04-game-library-discovery-run-2026-07-10T18-17-48-742Z-304902dc-abd4-4cd5-a4a2-77ea3e9d2233.json(workflow repo, not part of this PR).