Skip to content

Read mesh domains from vtk file 363#513

Merged
ktbolt merged 3 commits intoSimVascular:mainfrom
ktbolt:Read-mesh-domains-from-vtk-file_363
Mar 8, 2026
Merged

Read mesh domains from vtk file 363#513
ktbolt merged 3 commits intoSimVascular:mainfrom
ktbolt:Read-mesh-domains-from-vtk-file_363

Conversation

@ktbolt
Copy link
Copy Markdown
Collaborator

@ktbolt ktbolt commented Mar 3, 2026

Finish #363.

I also cleaned up the interface for VtkData.h.

I don't think there are any tests for this.

@ktbolt ktbolt requested review from kko27 and msbazzi March 3, 2026 20:30
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 3, 2026

Codecov Report

❌ Patch coverage is 0% with 50 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.75%. Comparing base (8df8135) to head (26a622f).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
Code/Source/solver/VtkData.cpp 0.00% 26 Missing ⚠️
Code/Source/solver/vtk_xml.cpp 0.00% 17 Missing ⚠️
Code/Source/solver/read_msh.cpp 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #513      +/-   ##
==========================================
- Coverage   67.85%   67.75%   -0.10%     
==========================================
  Files         168      168              
  Lines       32749    32797      +48     
  Branches     5748     5766      +18     
==========================================
  Hits        22221    22221              
- Misses      10391    10439      +48     
  Partials      137      137              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ktbolt ktbolt merged commit fbf70b4 into SimVascular:main Mar 8, 2026
8 checks passed
@javijv4
Copy link
Copy Markdown
Contributor

javijv4 commented Mar 25, 2026

@ktbolt, I was looking into this code to reuse some of these functions for the 3D-0D cap implementation. However, I noticed that the functions VtkVtpData::has_cell_data and VtkVtuData::has_cell_data (lines 801 and 1060 in VtkData.cpp) define the number of arrays using GetPointData() instead of GetCellData(). For example:

int num_arrays = impl->vtk_polydata->GetPointData()->GetNumberOfArrays();

when it should be,

int num_arrays = impl->vtk_polydata->GetCellData()->GetNumberOfArrays();

I am not sure if I should open a new issue or something else.

@ktbolt
Copy link
Copy Markdown
Collaborator Author

ktbolt commented Mar 25, 2026

@javijv4 Good catch !

This is a bug; open an Issue for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants