Repository navigation
ios-fleet: fixed marketing 0.1.0 with a dotted build - #331
Conversation
Code Review Completed! 🔥The code review was successfully completed based on your current configurations. Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
|
Task description is insufficient for business logic validation. 🤔 Insufficient Task ContextI found a task linked to this PR, but it only contains minimal information (title only, no description or acceptance criteria). To perform a meaningful business rules validation, I need more details. 🔍 What I need to validate:
💡 How to improve the task context:
|
…e, --build/--version/macOS guards, floor at patch, unknown store states fail closed)
…eased (fail closed)
…nd substitutions Both helpers run in a subshell, where the secrets temp dir and its EXIT trap die and the key is left behind. They check asc_credential_available instead, and a test guards it.
…(exit 4) instead of discarding stderr
This PR adds a fixed-marketing-version mode for iOS TestFlight ships.
Summary:
When
fixedMarketingVersion(e.g.1.1.2) is set inapps.json, the ship no longer counts up the marketing version per TestFlight. The marketing version stays fixed and the build number is a dottedM.m.<n>that increments inside that same train. First ship in an empty train isM.m.p(e.g.1.1.2 (1.1.2)), then1.1.3,1.1.4, etc. Absent key preserves the existing next-patch behavior, and an explicit--versionoverride still takes precedence.Functional changes:
READY_FOR_SALE,REPLACED_WITH_NEW_VERSION,REMOVED_FROM_SALE, pending / processing states, etc.M.m.ptrain: max existingM.m.<n>+ 1.ship-testflight.sh:fixedMarketingVersionon macOS where builds must grow across all trains.1.0.N (N)avoidance is skipped.M.m.<n>build shape.