Skip to content

ios-fleet: fixed marketing 0.1.0 with a dotted build - #331

Merged
jaywedgeworth22 merged 7 commits into
mainfrom
wise/ios-fleet-dotted-fixed
Oct 27, 2026
Merged

jaywedgeworth22 merged 7 commits into
mainfrom
wise/ios-fleet-dotted-fixed

Conversation

@jaywedgeworth22

@jaywedgeworth22 jaywedgeworth22 commented Oct 26, 2026 •

Copy link
Copy Markdown
Member

This PR adds a fixed-marketing-version mode for iOS TestFlight ships.

Summary:
When fixedMarketingVersion (e.g. 1.1.2) is set in apps.json, the ship no longer counts up the marketing version per TestFlight. The marketing version stays fixed and the build number is a dotted M.m.<n> that increments inside that same train. First ship in an empty train is M.m.p (e.g. 1.1.2 (1.1.2)), then 1.1.3, 1.1.4, etc. Absent key preserves the existing next-patch behavior, and an explicit --version override still takes precedence.

Functional changes:

  • Added read-only lookup for highest released App Store version across READY_FOR_SALE, REPLACED_WITH_NEW_VERSION, REMOVED_FROM_SALE, pending / processing states, etc.
  • Added read-only lookup for next dotted build in a M.m.p train: max existing M.m.<n> + 1.
  • ship-testflight.sh:
    • Uses fixed version automatically when configured.
    • Refuses to ship if fixed version is at or below the released App Store version — a released version closes its train.
    • Refuses fixedMarketingVersion on macOS where builds must grow across all trains.
    • In fixed mode, build comes only from the train itself — no floor, seed, commit-count, or patch-bump logic applies, and 1.0.N (N) avoidance is skipped.
    • Fails without shipping/bumping if ASC cannot be read or if the train contains a non-M.m.<n> build shape.

@kody-ai

kody-ai Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Code Review Completed! 🔥

The code review was successfully completed based on your current configurations.

Kody Guide: Usage and Configuration
Interacting with Kody
  • Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

  • Validate Business Logic: Ask Kody to validate your code against business rules by adding a comment with the @kody -v business-logic command.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Bug ✅
Performance ✅
Security ✅
Business Logic ✅

Access your configuration settings here.

​

Comment thread scripts/ios-fleet/asc-api.mjs Resolved
Comment thread scripts/ios-fleet/ship-testflight.sh Resolved
@kody-ai

kody-ai Bot commented Oct 26, 2026

Copy link
Copy Markdown

kody code-review Business Logic medium

Task description is insufficient for business logic validation.

🤔 Insufficient Task Context

I found a task linked to this PR, but it only contains minimal information (title only, no description or acceptance criteria). To perform a meaningful business rules validation, I need more details.

🔍 What I need to validate:

  • Business requirements and acceptance criteria
  • Expected behavior and business rules
  • Edge cases and constraints to consider

💡 How to improve the task context:

  • Add a description to the linked ticket
  • Include acceptance criteria or business rules
  • Describe the expected behavior after the change

⚠️ Important:

A task title alone is not sufficient to determine whether the implementation is correct or complete.


💡 This validation runs automatically only on the first review of a pull request. To run it again, comment @kody -v business-logic.

Prompt for LLM
Task description is insufficient for business logic validation.

<!-- task_context_status:weak -->
## 🤔 Insufficient Task Context

I found a task linked to this PR, but it only contains minimal information (title only, no description or acceptance criteria). To perform a meaningful business rules validation, I need more details.

### 🔍 What I need to validate:
- Business requirements and acceptance criteria
- Expected behavior and business rules
- Edge cases and constraints to consider

### 💡 How to improve the task context:
- Add a description to the linked ticket
- Include acceptance criteria or business rules
- Describe the expected behavior after the change

### ⚠️ Important:
A task title alone is not sufficient to determine whether the implementation is correct or complete.

---
> 💡 This validation runs automatically only on the first review of a pull request. To run it again, comment `@kody -v business-logic`.

​

Comment thread scripts/ios-fleet/asc-api.mjs Resolved
Comment thread scripts/ios-fleet/ship-testflight.sh Resolved
swu-wise Bot and others added 6 commits October 26, 2026 18:27
…e, --build/--version/macOS guards, floor at patch, unknown store states fail closed)
…nd substitutions

Both helpers run in a subshell, where the secrets temp dir and its EXIT trap die and the key is left behind.  They check asc_credential_available instead, and a test guards it.
@jaywedgeworth22
jaywedgeworth22 enabled auto-merge (squash) October 27, 2026 03:53
@swu-wise
swu-wise Bot disabled auto-merge October 27, 2026 03:55
@jaywedgeworth22
jaywedgeworth22 merged commit b85bd97 into main Oct 27, 2026
6 checks passed
@swu-claude
swu-claude Bot deleted the wise/ios-fleet-dotted-fixed branch November 5, 2026 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant